[Security Solution][Endpoint] Adjust Activity log date picker alignments #108504
Conversation
going with 350px instead of the 250px in the mock in order to fully show the placeholder text for now. see elastic/security-team/issues/1571
ashokaditya
added
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
ashokaditya
changed the title
| position: sticky; | ||
| top: ${(props) => props.theme.eui.euiSizeM}; | ||
| z-index: 1; | ||
| padding: ${(props) => `0 ${props.theme.eui.euiFontSizeM}`}; |
There was a problem hiding this comment.
i wonder if it's possible to use one of the more standard padding sizes like 16px or 24px since it seems kinda weird to use 18px, which looks like its usually used for font sizes
There was a problem hiding this comment.
@parkiino Yeah, I used 18px as that's what aligns it perfectly with the log content. I'm okay with using a 16px if we're okay with it being a little off. What do you think?
There was a problem hiding this comment.
Okay, I used a 16px and it looks alright I think. Let's go with that.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
ashokaditya
deleted the
fix/olm_activity_log_date_picker_alignments-1571
branch
…nts (elastic#108504) * set max width on date picker going with 350px instead of the 250px in the mock in order to fully show the placeholder text for now. see elastic/security-team/issues/1571 * pad date picker to align with activity log content see elastic/security-team/issues/1571 * use padding sizes instead review comments Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…nts (#108504) (#108706) * set max width on date picker going with 350px instead of the 250px in the mock in order to fully show the placeholder text for now. see elastic/security-team/issues/1571 * pad date picker to align with activity log content see elastic/security-team/issues/1571 * use padding sizes instead review comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ashokaditya <[email protected]>
Summary
Modifies the activity log date range picker alignment and width.
I've used a
350pxwidth instead of a250pxas in the figma mock to show the placeholder text.This would change when we implement the Super Date Picker component instead of the date range picker in a later PR.
250px (as in mock)
350px (in this change)
Checklist
Delete any items that are not applicable to this PR.