Rewrite Grok Debugger Tests to use Standard Functional Test Runner #108301
Conversation
|
Fixed the Grok debugger tests and ran through flaky test runner. https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1810/ |
cuff-links
added
Feature:Grok Debugger
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
cuff-links
added
v7.15.0
release_note:skip
|
Also an unrelated failure in a different test group. |
There was a problem hiding this comment.
Nice job @cuff-links! Great to see these tests refactored and converted to TS. Ran tests successfully locally.
I left a few comments/questions in the code that I'd like to get more information on before approving. Also, is there still an open issue for these flaky tests? If so, can you link to it in the PR description?
| expect(response).to.eql(testData); | ||
| }); | ||
|
|
||
| // This test will need to be fixed. |
There was a problem hiding this comment.
Can you explain what's wrong with this test and why we need to still skip it?
There was a problem hiding this comment.
The UI has changed since this test was last working. I will need to actually rewrite this test from the ground up. The current PR is just about migrating the existing tests to use current conventions to aid with flakiness. So fixing this other test should be fixed as part of a separate since that wasn't the purpose of this PR.
There was a problem hiding this comment.
Thanks for the explanation! As discussed 1:1, if you can open a separate issue to address this so we do lose track of it that'd be great. It'd also be helpful if you can reference the issue link in the code comment.
|
@cuff-links I believe this PR should also be tagged with |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Latest changes LGTM. Thanks @cuff-links! Added a note about opening an issue to address the skipped test.
|
New issue opened #108814 |
…lastic#108301) * Converted Grok debugger tests to use standard functional test runner practices. * Fixed last test. * Removed old test now that the new test is passing. * Fixed condition for retry. * Removed .only to restore test run. * fixed errors * Fixed nits.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…108301) (#108815) * Converted Grok debugger tests to use standard functional test runner practices. * Fixed last test. * Removed old test now that the new test is passing. * Fixed condition for retry. * Removed .only to restore test run. * fixed errors * Fixed nits. Co-authored-by: John Dorlus <[email protected]>
This functional test addresses the constant failures that happen with the grok debugger tests. These tests have been rewritten to use standard functional test runner practices, which they weren't before. This is in hopes to address the consistent flakiness of these tests.