-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Update rules detail page to resolve SO IDs if necessary #108091
[Alerting] Update rules detail page to resolve SO IDs if necessary #108091
Conversation
…ing/use-resolve-in-rule-details
…ing/use-resolve-in-rule-details
Left a comment about adding a e2e test for this when the changes are made to the alerting SO to make it share-capable for 8.0 |
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works as described.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
History
To update your PR or re-run it, just comment with: cc @ymao1 |
…lastic#108091) * Adding internal resolve API to resolve rules given an ID * Updating after merge * Updating after merge * Adding resolveRule api to client and adding spacesOss plugin dependency * Handling 404 errors by calling resolve. Updating unit tests * Handling aliasMatch and conflict results * Fixing types * Unit tests for spaces oss components * Adding audit event for resolve Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…108091) (#109194) * Adding internal resolve API to resolve rules given an ID * Updating after merge * Updating after merge * Adding resolveRule api to client and adding spacesOss plugin dependency * Handling 404 errors by calling resolve. Updating unit tests * Handling aliasMatch and conflict results * Fixing types * Unit tests for spaces oss components * Adding audit event for resolve Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]>
Resolve #108074
Summary
This PR:
resolve
HTTP API that calls the saved objects resolve functionresolve
API. Handling for non-404 errors is unchanged.spacesOss
UI components toaliasMatch
conflict
To Verify
yarn es snapshot --ssl -E path.data=../data
and create some rules, including rules in a non-default spacemultiple-isolated
and setconvertToMultiNamespaceTypeVersion: '8.0.0' in
x-pack/plugins/alerting/server/saved_objects/index.ts`x-pack/plugins/alerting/server/saved_objects/migrations.ts
resolve
request when you go to the bookmarked URL. You should be redirected to the rule details page for the updated rule ID and you should see a toaster pop up.conflict
outcome but if you want to see theconflict
callout, you could modifyx-pack/plugins/triggers_actions_ui/public/application/sections/alert_details/components/alert_details_route.tsx
to set the outcome toconflict
after the resolve call.Checklist