[APM] Default env for creating rule outside of APM app #107942
Conversation
|
Pinging @elastic/apm-ui (Team:apm) |
|
@dgieselaar would it be possible to fix the transaction type too? |
dgieselaar
added
release_note:skip
|
@cauemarcondes added a fix for that as well, looks like it's a 7.15 only bug. |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| @@ -90,6 +91,8 @@ export function TransactionDurationAlertTrigger(props: Props) { | |||
| threshold: 1500, | |||
| windowSize: 5, | |||
| windowUnit: 'm', | |||
| environment: ENVIRONMENT_ALL.value, | |||
| transactionType: transactionTypes[0], | |||
| } | |||
| ); | |||
There was a problem hiding this comment.
We could make it clear to users that they cannot create alerts from here:
| ); | |
| ); | |
| if(!metadata?.serviceName) { | |
| return <EuiCallout>Creating alerts from here is not supported. Please go to the [APM app](link))</EuiCallout> | |
| } |
There was a problem hiding this comment.
Yes, I saw. I was hoping we could do something for 7.15 - like adding a callout to at least let the user know that they cannot create alerts.
Implementing the free form field with suggestions is much better but likely to be a bigger task and not something we'll get around to before FF.
dgieselaar
added
the
auto-backport
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…8042) Co-authored-by: Dario Gieselaar <[email protected]>
Closes #107610.
Sets environment to "All" when rules are created outside of the APM app.
Note that the transaction duration rule cannot be created at all due to
serviceNamenot being available, which it needs. As this needs design, I've opened a separate issue for this: #107940