[Maps] filtered out docs with empty entity ids for tracks and top-hits layers

[nreese]

Fixes #105599

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[nreese]

Failed functional test documents source - geo top hits - split on scripted field - should display top hits per entity highlights an interesting property of the filter, It removed the 0 bucket. Not sure why. The bucket below is missing when the PR is applied.

{
            "key": "0",
            "doc_count": 22,
            "entityHits": {
              "hits": {
                "total": {
                  "value": 22,
                  "relation": "eq"
                },
                "max_score": null,
                "hits": [
                  {
                    "_index": "logstash-2015.09.22",
                    "_id": "AU_x3_g3GFA8no6QjkA4",
                    "_score": null,
                    "fields": {
                      "@timestamp": [
                        "2015-09-22T00:51:30.049Z"
                      ],
                      "utc_time": [
                        "2015-09-22T00:51:30.049Z"
                      ],
                      "relatedContent.article:modified_time": [
                        "2014-11-26T04:09:29.000Z"
                      ],
                      "geo.coordinates": [
                        "37.8583055594936, -80.3994722943753"
                      ],
                      "relatedContent.article:published_time": [
                        "2006-02-19T03:02:20.000Z"
                      ]
                    },
                    "sort": [
                      1442883090049
                    ]
                  }
                ]
              }
            }
          },

Generated filter.

"must_not": [
        {
          "script": {
            "script": {
              "source": "boolean compare(Supplier s, def v) {return s.get() == v;}compare(() -> { doc['@timestamp'].value.getHour() }, params.value);",
              "lang": "painless",
              "params": {
                "value": 0
              }
            }
          }
        }
      ]

[thomasneirynck]

this is because of

kibana/packages/kbn-es-query/src/filters/build_filters/get_converted_value_for_field.ts

Line 32 in eeb88b0

return Number(value);

For scripted-fields, it looks at the field-type and coerces the value to a number.

Wondering if we should use the exist-filter here:

kibana/packages/kbn-es-query/src/filters/build_filters/exists_filter.ts

Line 45 in c048f71

export const buildExistsFilter = (field: IndexPatternFieldBase, indexPattern: IndexPatternBase) => {

. (although, this would only help with sparsity, but not with empty-values)

Also - to. be fair, I'm not sure if this is a bug perse, since this hits an edge-case (ie. users using a numeric pivot-field, which I would guess is very rare). I think this PR could still capture 95% of use-cases, if we add this filter only for fields of type string.

[nreese]

@elasticmachine merge upstream

[nreese]

I think this PR could still capture 95% of use-cases, if we add this filter only for fields of type string.

I have added a check to ensure the field is a string before adding the filters

[thomasneirynck]

thx, this is a nice one

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 37b5c1e
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
maps	3.2MB	3.2MB	+544.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
maps	604	619	+15

History

• 💔 Build #144116 failed 514c35d
• 💔 Build #143060 failed 24b8853
• 💔 Build #143044 failed 5ad5b49

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.