[Stack Monitoring] Rename alerts to rules #107654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
the
release_note:skip
neptunian
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @neptunian |
neptunian
force-pushed
the
107551-rename-alerts-to-rules
branch
from
77f9fb9 to
4f31267
Compare
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @neptunian |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Aug 10, 2021
* rename constants and alert types to rules * update test language * update BaseRule properties to rule * change rawAlert to sanitizedRule Co-authored-by: Kibana Machine <[email protected]>
neptunian
added a commit
that referenced
this pull request
Aug 10, 2021
* rename constants and alert types to rules * update test language * update BaseRule properties to rule * change rawAlert to sanitizedRule Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#107551
Changes many variables that reference what is now referred to as a rule to "rule" in accordance with recent terminology changes from Kibana Alerting. Some changes still refer to types called "Alerts" as described in the documentation that has not yet changed. I went ahead and changed some of these to "rule" but left others where I'm not sure if it will change. Once Alerting updates their types, we can update more of ours to reflect them. There are many components still referring to "alerts" instead of rules but I am hoping we can do this on a case by case basis as we work on them as it's not always so straightforward.