Added tests for dot notation processors.

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/__jest__/processors/dot_expander.test.tsx

@@ -0,0 +1,122 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { act } from 'react-dom/test-utils';
+import { setup, SetupResult, getProcessorValue } from './processor.helpers';
+
+const DOT_EXPANDER_TYPE = 'dot_expander';
+
+describe('Processor: Dot Expander', () => {
+  let onUpdate: jest.Mock;
+  let testBed: SetupResult;
+
+  beforeAll(() => {
+    jest.useFakeTimers();
+  });
+
+  afterAll(() => {
+    jest.useRealTimers();
+  });
+
+  beforeEach(async () => {
+    onUpdate = jest.fn();
+
+    await act(async () => {
+      testBed = await setup({
+        value: {
+          processors: [],
+        },
+        onFlyoutOpen: jest.fn(),
+        onUpdate,
+      });
+    });
+
+    testBed.component.update();
+
+    // Open flyout to add new processor
+    testBed.actions.addProcessor();
+    // Add type (the other fields are not visible until a type is selected)
+    await testBed.actions.addProcessorType(DOT_EXPANDER_TYPE);
+  });
+
+  test('prevents form submission if required fields are not provided', async () => {
+    const {
+      actions: { saveNewProcessor },
+      form,
+    } = testBed;
+
+    // Click submit button with only the type defined
+    await saveNewProcessor();
+
+    // Expect form error as "field" is a required parameter
+    expect(form.getErrorsMessages()).toEqual(['A field value is required.']);
+  });
+
+  test('prevents form submission if field does not contain a . for the dot notation', async () => {
+    const {
+      actions: { saveNewProcessor },
+      form,
+      component,
+    } = testBed;
+
+    // Add invalid "field" value (required)
+    form.setInputValue('fieldNameField.input', 'missingTheDot');
+
+    // Save the processor with invalid field
+    await saveNewProcessor();
+
+    // Move ahead the debounce time which will then execute any validations
+    await act(async () => {
+      jest.runAllTimers();
+    });
+    component.update();
+
+    // Expect form error as "field" does not contain '.'
+    expect(form.getErrorsMessages()).toEqual([
+      'A field value requires at least one dot character.',
+    ]);
+  });
+  test('saves with default parameter values', async () => {
+    const {
+      actions: { saveNewProcessor },
+      form,
+    } = testBed;
+
+    // Add "field" value (required)
+    form.setInputValue('fieldNameField.input', 'field.with.dot');
+
+    // Save the field
+    await saveNewProcessor();
+
+    const processors = getProcessorValue(onUpdate, DOT_EXPANDER_TYPE);
+    expect(processors[0][DOT_EXPANDER_TYPE]).toEqual({
+      field: 'field.with.dot',
+    });
+  });
+
+  test('allows optional parameters to be set', async () => {
+    const {
+      actions: { saveNewProcessor },
+      form,
+    } = testBed;
+
+    // Add "field" value (required)
+    form.setInputValue('fieldNameField.input', 'field.notation');
+
+    // Set optional parameters
+    form.setInputValue('pathField.input', 'somepath');
+
+    // Save the field with new changes
+    await saveNewProcessor();
+
+    const processors = getProcessorValue(onUpdate, DOT_EXPANDER_TYPE);
+    expect(processors[0][DOT_EXPANDER_TYPE]).toEqual({
+      field: 'field.notation',
+      path: 'somepath',
+    });
+  });
+});

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/__jest__/processors/processor.helpers.tsx

@@ -146,6 +146,7 @@ type TestSubject =
   | 'fieldNameField.input'
   | 'messageField.input'
   | 'mockCodeEditor'
+  | 'pathField.input'
   | 'tagField.input'
   | 'typeSelectorField'
   | 'dateRoundingField'

x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/components/processor_form/processors/dot_expander.tsx

@@ -54,7 +54,12 @@ export const DotExpander: FunctionComponent = () => {
         ]}
       />
 
-      <UseField config={fieldsConfig.path} component={Field} path="fields.path" />
+      <UseField
+        data-test-subj="pathField"
+        config={fieldsConfig.path}
+        component={Field}
+        path="fields.path"
+      />
     </>
   );
 };