Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Sharing Saved Objects developer guide steps #107256

Closed
wants to merge 4 commits into from

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Jul 30, 2021

[skip-ci]

This PR is a proof-of-concept. It is designed to be a companion for the Sharing Saved Objects developer guide (added in #107099).

Example steps #

The proof-of-concept adds a new example plugin called Notes Test (added in a084bf0). This plugin registers an isolated "note" saved object type (namespaceType: 'single'). The subsequent commits walk through the steps of the developer guide to convert the "note" objects to become share-capable.

  • Initial commit: 30b8fe6
  • Step 1: (not covered in this POC)
  • Step 2: c02076e
  • Step 3: 5b1a467
  • Step 4: 2fd4c42
  • Step 5: (not covered in this POC)

Using the example plugin

Open Kibana and use the main navigation pane to view the Notes Test app. You can use this page to view a table of notes or create a new note. You can click an existing note to view its body text.

notes-test

@jportner jportner added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 30, 2021
@jportner jportner changed the title POC: Sharing Saved Objects POC: Sharing Saved Objects developer guide steps Jul 30, 2021
@jportner jportner closed this Jul 30, 2021
@elastic elastic deleted a comment from kibanamachine Jul 30, 2021
@elastic elastic deleted a comment from kibanamachine Aug 9, 2021
@elastic elastic deleted a comment from kibanamachine Aug 9, 2021
@jportner jportner reopened this Aug 11, 2021
@jportner jportner force-pushed the poc-sharing-saved-objects branch from d3fcabe to 531730d Compare August 11, 2021 13:54
@jportner jportner closed this Aug 11, 2021
Created the test plugin with basic functionality. Subsequent commits
will demonstrate individual steps that need to be taken, as described
by the Sharing Saved Objects developer guide.

Note: this simple test plugin doesn't use links to other object types,
so Step 1 is skipped intentionally.
This step demonstrates the changes to update client code to use the new
SavedObjectsClient `resolve()` method instead of `get()`.
This step demonstrates the changes to update client code to correctly
handle the three different `resolve()` outcomes. It adds an optional
dependency on the Spaces plugin, and uses the SpacesApi to change the UI
if necessary.
This step demonstrate the changes to update the saved object type
registration, which will cause this isolated object type to be converted
to become share-capable during the 8.0 upgrade process.

Note: the previous steps can be backported to 7.x, but this step cannot
be backported, because the conversion cannot take place before 8.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant