Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Improve functional testing searchOnPageLoad #107181

Conversation

kertal
Copy link
Member

@kertal kertal commented Jul 29, 2021

Summary

This PR stabilizes the check for the number of fetches in Discover, by using a retry.

Flaky test runner said: yes - 1 failure, but not related to this fix

Fixes #105312

Checklist

Delete any items that are not applicable to this PR.

@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 29, 2021
@kertal kertal self-assigned this Jul 29, 2021
@kertal kertal changed the title [Discover] Improve functional test [Discover] Improve functional testing searchOnPageLoad Jul 30, 2021
@kertal kertal added v7.14.1 v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 30, 2021
@kertal kertal marked this pull request as ready for review August 2, 2021 05:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Aug 2, 2021

@elasticmachine merge upstream

@kertal kertal requested a review from majagrubic August 2, 2021 05:07
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did flaky spec runner approve this as well? :)

@kertal
Copy link
Member Author

kertal commented Aug 2, 2021

Did flaky spec runner approve this as well? :)

sure :) https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1798/

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 2, 2021
kibanamachine added a commit that referenced this pull request Aug 2, 2021
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.1 v7.15.0 v8.0.0
Projects
None yet
4 participants