Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix tests warnings #107147

Merged
merged 1 commit into from
Jul 30, 2021
Merged

[Lens] fix tests warnings #107147

merged 1 commit into from
Jul 30, 2021

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 29, 2021 •
edited
Loading

Summary

Fixes the warnings about canvas:
Screenshot 2021-07-29 at 14 05 55

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 29, 2021
@mbondyra mbondyra requested a review from a team July 29, 2021 12:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra requested review from stratoula and dej611 July 29, 2021 12:06
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code review only

@mbondyra mbondyra merged commit 6da99f3 into elastic:master Jul 30, 2021
@mbondyra mbondyra deleted the lens/warnings_in_test branch July 30, 2021 07:26
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 30, 2021
@mbondyra @kibanamachine
mocking canvas (elastic#107147)
680d761
@kibanamachine kibanamachine mentioned this pull request Jul 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 30, 2021
@kibanamachine @mbondyra
mocking canvas (#107147) (#107260)
d40feb5 
Co-authored-by: Marta Bondyra <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mbondyra @vadimkibana
mocking canvas (elastic#107147)
aeb089d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@dej611 dej611 Awaiting requested review from dej611

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbondyra @elasticmachine @kibanamachine @stratoula