Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix suffix field format leaks to index pattern management #107139

Merged
merged 2 commits into from
Aug 2, 2021
Merged

[Lens] Fix suffix field format leaks to index pattern management #107139

merged 2 commits into from
Aug 2, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jul 29, 2021

Summary

fix #106839

The idea behind hidden flag is that this field formatter is only accessible directly by id, which is, I assume, what lens does for now.

Looks like suffix in Lens is unfinished features, and I wasn't able to properly test the suffix functionality in Lens following the steps from #82852

Checklist

@Dosant Dosant added release_note:fix v7.15.0 v8.0.0 Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed Feature:FieldFormatters labels Jul 29, 2021
@Dosant Dosant marked this pull request as ready for review July 29, 2021 13:03
@Dosant Dosant requested review from a team and dej611 July 29, 2021 13:03
@mbondyra mbondyra self-requested a review August 2, 2021 07:33
@mbondyra
Copy link
Contributor

mbondyra commented Aug 2, 2021

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Chrome, code LGTM 🆗

@Dosant Dosant enabled auto-merge (squash) August 2, 2021 08:36
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +36.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 1b315bb into elastic:master Aug 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2021
@Dosant @kibanamachine
[Lens] Fix suffix field format leaks to index pattern management (ela…
8d21272 
…stic#107139)
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 2, 2021
@kibanamachine @Dosant
[Lens] Fix suffix field format leaks to index pattern management (#10…
4038e14 
…7139) (#107383)

Co-authored-by: Anton Dosov <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@Dosant @vadimkibana
[Lens] Fix suffix field format leaks to index pattern management (ela…
d8f8b79 
…stic#107139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@dej611 dej611 Awaiting requested review from dej611

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:FieldFormatters Feature:Lens release_note:fix v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Suffix field format leaks to index pattern management
3 participants
@Dosant @mbondyra @kibanamachine