Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task Manager] Fix broken health test #107036

Merged
merged 2 commits into from
Jul 30, 2021
Merged

[Task Manager] Fix broken health test #107036

merged 2 commits into from
Jul 30, 2021

Conversation

chrisronline
Copy link
Contributor

Resolves #106350
Resolves #106388

The test was incorrectly looking at the wrong mock call for the warn and error test. This means the test would sometimes pass if the test run quickly enough but definitely a code bug leading to the flaky behavior.

@chrisronline chrisronline added review v8.0.0 Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 labels Jul 28, 2021
@chrisronline chrisronline requested a review from a team as a code owner July 28, 2021 15:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chrisronline chrisronline added the release_note:skip Skip the PR/issue when compiling release notes label Jul 28, 2021
ymao1
ymao1 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is no way to run the flaky test runner on jest tests? LGTM on green CI

YulNaumenko
YulNaumenko approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit caee125 into elastic:master Jul 30, 2021
@chrisronline chrisronline deleted the alerting/broken_health_test branch July 30, 2021 19:19
@chrisronline chrisronline mentioned this pull request Jul 30, 2021
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jul 30, 2021
@chrisronline @kibanamachine
Fix broken health test (elastic#107036)
2368f4c 
Co-authored-by: Kibana Machine <[email protected]>
chrisronline added a commit that referenced this pull request Jul 30, 2021
@chrisronline @kibanamachine
Fix broken health test (#107036) (#107328)
b3cc00c 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@chrisronline @kibanamachine @vadimkibana
Fix broken health test (elastic#107036)
3d46ac2 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes review Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@chrisronline @elasticmachine @kibanamachine @ymao1 @YulNaumenko