Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Datasource refactored. #106640

Merged
merged 2 commits into from
Jul 26, 2021
Merged

[Canvas] Datasource refactored. #106640

merged 2 commits into from
Jul 26, 2021

Conversation

Kuznietsov
Copy link
Contributor

At this PR refactoring of the Datasource HOC was done.

Based on the x-pack/plugins/canvas/CONTRIBUTING.md, recompose has been removed in favor of React hooks at Datasource.

@Kuznietsov Kuznietsov added refactoring Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:Canvas auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 23, 2021
@Kuznietsov Kuznietsov requested review from crob611 and alexwizp July 23, 2021 12:31
@Kuznietsov Kuznietsov self-assigned this Jul 23, 2021
@Kuznietsov Kuznietsov requested a review from a team as a code owner July 23, 2021 12:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

crob611
crob611 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough 👍

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.5MB 1.5MB -202.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov merged commit 89b8dc6 into elastic:master Jul 26, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 26, 2021
@Kuznietsov @kibanamachine
Datasource refactored from recompose to hooks. (elastic#106640)
e87eb67 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Jul 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

Kuznietsov added a commit to Kuznietsov/kibana that referenced this pull request Jul 26, 2021
@Kuznietsov @kibanamachine
[Canvas] Datasource refactored. (elastic#106640)
ed75ba7 
Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 26, 2021
@kibanamachine @Kuznietsov
Datasource refactored from recompose to hooks. (#106640) (#106679)
8ba446f 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Yaroslav Kuznietsov <[email protected]>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@Kuznietsov @kibanamachine @vadimkibana
Datasource refactored from recompose to hooks. (elastic#106640)
b19b396 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kuznietsov @elasticmachine @kibanamachine @crob611