-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Supporting share-capable saved objects for rules and connectors #106630
Closed
+3,853
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The existing test data archive did not decrypt properly without the migration additions; it appears that was not encrypted with the same key that is used by the functional test server. I replaced that test data with fresh data that does decrypt properly. * I added empty ESO migration functions for the alert and action saved object types so they will be decrypted and re-encrypted during the index migration process. Note that the alias match test will not pass until the associated ESO service bugfix is applied.
A bug in the algorithm neglected to differentiate when a converted object may have had its ID changed (this happens when an object exists in a non-default space and then it is converted). This commit fixes the bug and adds several more unit tests and integration tests to exercise different permutations of migrations.
This was referenced Jul 28, 2021
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner successfully executes the taskStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner actionsPlugin.execute is called per alert instance that is scheduledStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/alerting/server/task_runner.Task Runner actionsPlugin.execute is called per alert instance that is scheduled (with ephemeral support)Standard Out
Stack Trace
and 147 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.