-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph] Deangularize graph app controller #106587
Merged
dimaanj
merged 45 commits into
elastic:master
from
dimaanj:remove-angular-from-control-panel
Aug 31, 2021
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
ad2a44d
[Graph] deaungularize control panel
dimaanj ea2356c
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine 22b3ec8
Merge branch 'master' of https://github.com/elastic/kibana into remov…
dimaanj 6e169e7
[Graph] move main graph directive to react
dimaanj 5bb2f8f
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine 80e5e20
Merge branch 'master' of https://github.com/elastic/kibana into remov…
dimaanj d1e8b7e
[Graph] refactoring
dimaanj 4783be2
[Graph] remove redundant memoization, update import
dimaanj e9936c7
[Graph] fix settings menu, clean up the code
dimaanj 2a6661b
Merge branch 'master' of https://github.com/elastic/kibana into remov…
dimaanj e9af2a5
[Graph] fix graph settings
dimaanj defe0e5
[Graph] code refactoring, fixing control panel render issues
dimaanj b6f8980
[Graph] fix small mistake
dimaanj 26b108a
[Graph] rename components
dimaanj 1a3fdde
[Graph] fix imports
dimaanj a345ca6
[Graph] fix graph search and inspect panel
dimaanj 4ceb34b
[Graph] remove redundant types
dimaanj 74881da
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine 31e6711
[Graph] fix problem with selection list
dimaanj 7fc58c5
[Graph] fix functional test which uses selection list
dimaanj 9bf8506
[Graph] fix unit tests, update types
dimaanj 8aa27ae
[Graph] fix types
dimaanj 3cd5899
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine f208fc8
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine d21d837
[Discover] fix url queries
dimaanj a7bc9b2
[Graph] fix types
dimaanj 080c993
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine f875833
[Graph] add react router, remove angular stuff
dimaanj 5fcd8ff
[Graph] fix styles
dimaanj ed3dc7f
[Graph] fix i18n
dimaanj c8fe5e2
[Graph] fix navigation to a new workspace creation
dimaanj 62a6925
[Graph] fix issues from comments
dimaanj 3f7b3f9
[Graph] add suggested changed
dimaanj e1192a5
Update x-pack/plugins/graph/public/components/graph_visualization/gra…
dimaanj 32be3b4
[Graph] remove brace lib from imports
dimaanj 6bdffeb
[Graph] fix url navigation between workspaces, fix types
dimaanj a002fcf
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine a7a930a
[Graph] refactoring, fixing url issue
dimaanj 547dbd2
[Graph] update graph dependencies
dimaanj 271ed75
[Graph] add comments
dimaanj d65e132
[Graph] fix types
dimaanj 0da7071
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine 7ed9068
[Graph] fix new button, fix control panel styles
dimaanj 3e6bac2
[Graph] apply suggestions
dimaanj fbd54b4
Merge branch 'master' into remove-angular-from-control-panel
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
362 changes: 0 additions & 362 deletions
362
x-pack/plugins/graph/public/angular/templates/index.html
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
x-pack/plugins/graph/public/angular/templates/listing_ng_wrapper.html
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this adds a bit of padding to the
node labels, but it's not clear what problem this addresses. Out of curiosity, was there a particular situation that led to this addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was mistakenly leaved and can be removed in a follow up PR.