[Fleet] OpenAPI - add missing routes and clean up names, types, etc #106464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
jfsiii
added
release_note:skip
added 10 commits
July 21, 2021 16:01
jfsiii
changed the title
nchaulet
approved these changes
Jul 22, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jfsiii |
22 tasks
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 22, 2021
…lastic#106464) ### Add specs for several missing routes See additions in `openapi/entrypoint.yaml` - `/agents/{agentId}/reassign` - `/agents/bulk_reassign` - `/agents/bulk_unenroll` - `/package_policies/delete` ### Add enum of string values for delete package response See 5c04dfc ### Fixed inaccurate operation spec spec for `delete-agent-policy` operation currently shows it accepting an array of ids`agentPolicyIds: string[]` and returning an array of results, but it actually accepts a single `agentPolicyId: string` id an returns a single object ### Internal changes #### Better / more consistent operation names e.g. ```diff - operationId: post-agent-policy + operationId: create-agent-policy ``` and ```diff - operationId: put-agent-policy-agentPolicyId + operationId: update-agent-policy ``` #### Better schema titles e.g. ```diff - title: UpdatePackagePolicy + title: Update package policy ```
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 22, 2021
…lastic#106464) ### Add specs for several missing routes See additions in `openapi/entrypoint.yaml` - `/agents/{agentId}/reassign` - `/agents/bulk_reassign` - `/agents/bulk_unenroll` - `/package_policies/delete` ### Add enum of string values for delete package response See 5c04dfc ### Fixed inaccurate operation spec spec for `delete-agent-policy` operation currently shows it accepting an array of ids`agentPolicyIds: string[]` and returning an array of results, but it actually accepts a single `agentPolicyId: string` id an returns a single object ### Internal changes #### Better / more consistent operation names e.g. ```diff - operationId: post-agent-policy + operationId: create-agent-policy ``` and ```diff - operationId: put-agent-policy-agentPolicyId + operationId: update-agent-policy ``` #### Better schema titles e.g. ```diff - title: UpdatePackagePolicy + title: Update package policy ```
kibanamachine
added a commit
that referenced
this pull request
Jul 22, 2021
…106464) (#106539) ### Add specs for several missing routes See additions in `openapi/entrypoint.yaml` - `/agents/{agentId}/reassign` - `/agents/bulk_reassign` - `/agents/bulk_unenroll` - `/package_policies/delete` ### Add enum of string values for delete package response See 5c04dfc ### Fixed inaccurate operation spec spec for `delete-agent-policy` operation currently shows it accepting an array of ids`agentPolicyIds: string[]` and returning an array of results, but it actually accepts a single `agentPolicyId: string` id an returns a single object ### Internal changes #### Better / more consistent operation names e.g. ```diff - operationId: post-agent-policy + operationId: create-agent-policy ``` and ```diff - operationId: put-agent-policy-agentPolicyId + operationId: update-agent-policy ``` #### Better schema titles e.g. ```diff - title: UpdatePackagePolicy + title: Update package policy ``` Co-authored-by: John Schulz <[email protected]>
jen-huang
pushed a commit
that referenced
this pull request
Jul 22, 2021
…106464) (#106540) ### Add specs for several missing routes See additions in `openapi/entrypoint.yaml` - `/agents/{agentId}/reassign` - `/agents/bulk_reassign` - `/agents/bulk_unenroll` - `/package_policies/delete` ### Add enum of string values for delete package response See 5c04dfc ### Fixed inaccurate operation spec spec for `delete-agent-policy` operation currently shows it accepting an array of ids`agentPolicyIds: string[]` and returning an array of results, but it actually accepts a single `agentPolicyId: string` id an returns a single object ### Internal changes #### Better / more consistent operation names e.g. ```diff - operationId: post-agent-policy + operationId: create-agent-policy ``` and ```diff - operationId: put-agent-policy-agentPolicyId + operationId: update-agent-policy ``` #### Better schema titles e.g. ```diff - title: UpdatePackagePolicy + title: Update package policy ``` Co-authored-by: John Schulz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR changes in example viewer
Add specs for several missing routes
See additions in
openapi/entrypoint.yaml/agents/{agentId}/reassign/agents/bulk_reassign/agents/bulk_unenroll/package_policies/deleteAdd enum of string values for delete package response
See 5c04dfc
Fixed inaccurate operation spec
spec for
delete-agent-policyoperation currently shows it accepting an array of idsagentPolicyIds: string[]and returning an array of results, but it actually accepts a singleagentPolicyId: stringid an returns a single objectInternal changes
Better / more consistent operation names
e.g.
and
Better schema titles
e.g.
Checklist