[Runtime field editor] Component integration test for preview

[sebelga]

This PR adds the component integration tests for the preview panel inside the runtime field editor. While adding the tests I found a few issues around timings and inconsistencies when updating some states (I found them while doing QA with throttling on "Slow 3G"). Specially when switching between cluster data and loading a custom doc ID.

I am confident that the code is more robust now and the tests should give us a very high level of confidence against future regressions. 👍

Preview for concrete fields

I've also enabled the preview for concrete field when the "Set format" is turned on.

[sebelga]

I have moved the logic to fetch the document inside the preview context file to have a single place to look at for fetching document. This also allows us to keep the state when the doc navigation is unmounted (for example when showing the empty prompt)

[yuliacech]

I wonder if this expression could be made more readable by splitting into several if/else statement with isEmptyPromptVisible being false by default? I find multiple ternary operators very complex to understand.

[sebelga]

You right, your suggestion will make it easier to follow. I'll make the change 👍

[yuliacech]

Hi @sebelga, great work! I think adding so many tests makes this feature way more robust and stable!
I followed the tests and tried out everything locally. The preview works as expected and I haven't noticed any bugs.

I'd like to comment on some UX that might be improved in a follow up work and are not blockers for this PR:

• When the error is too long, it goes out of the callout, I like to use EUI's utility classes to fix this (eui-textBreakWord or eui-textBreakAll)

• Pinned fields are not preserved between a custom document ID and loading documents from the cluster
  

• When the document changes, the field's preview is updating (which is indicated on the top of the flyout), but there is no indication for that at the field itself. It might be confusing when the value just suddenly changes, especially when other fields have already been loaded from the document (I tested this on 'Slow 3G')
  

[sebelga]

Thanks for the review @yuliacech! You made some great UX enhancement suggestions. I added them in the backlog and will address them as a separate chunk of work. 👍

[mattkime]

src/plugins/index_pattern_field_editor/__jest__/client_integration/field_editor.test.tsx:78 - has 'TODO' as content - is this intentional?

[mattkime]

Left just one comment which I'll let you address as you please. I really like how detailed these jest tests are. I must admit that I'm new to using act and testBed in tests so while I'm reviewing as best I can, someone else might be more rigorous. Thanks!

[mattkime]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2f73d56
• Storybooks Preview

History

• 💚 Build #140954 succeeded 937f2fa
• 💚 Build #140807 succeeded 04084c718aec8e17fb93d6116bce52c27757ae30
• 💚 Build #140098 succeeded e794b0a607b51ed70e2a52ed981a41229ea13ba4
• 💔 Build #140051 failed 0aee6951c23998b5fca17780041b81c7bf888a0b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[sebelga]

Thanks for the review @mattkime !

has 'TODO' as content - is this intentional?

Good catch, I removed the TODO as it has been covered. 👍

[cjcenizal]

@sebelga Could you please add labels to this PR, too?

[elasticmachine]

Pinging @elastic/kibana-stack-management (Team:Stack Management)