-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes tag saved object namespaceType to multiple-isolated #106341
Changes tag saved object namespaceType to multiple-isolated #106341
Conversation
@elasticmachine merge upstream |
@jportner Should this be backported to 7.x? I'm guessing the I wonder if we should change the release note on this PR to clarify that this is only a breaking change for URLs if you have custom plugins that use tags IDs in the URLs (since no 1st party code uses tag IDs in the URL). We should also add a note about tag IDs changing on the SO API. Maybe there's a "template" of sorts we should create for the SO API release notes for each type since the guidance would largely be the same for each type that is affected by this conversion. That, or we should just have a single release note for the SO API ID changes that mentions all affected types in 8.0. |
No, we have validation in place specifically to prevent
I vote for a single release note. We have dozens of affected types, I don't think such repetitive release notes will be helpful. |
On hold pending decision on when to change all SO types to become share capable. |
@elasticmachine merge upstream |
@TinaHeiligers Joe will do a single release note for the breaking change across all saved object types, but each team is responsible for converting their own types, there won't be a single big commit, so we should go ahead and merge this. |
Agree that we should just do a single release note. We were waiting on this as we had some open discussions about potentially delaying the conversion past 8.0, but it looks like we hopefully won't need to do that after all. So I think we can merge this and revert it later if we absolutely have to. |
@jportner Thanks for the head's up! I'll merge once CI passes. |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
@jportner The PR is merged. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Resolves #102870
We potentially want to make the tag type shareable in the (near?) future, we need to change its namespaceType to multiple-isolated before 8.0.
A more pressing priority is that other saved objects (dashboard, visualizations, maps and lens) can reference tags, and all SO's that can be referenced need to be converted too.
This PR only changes the
namespaceType
fromsingle
tomultiple-isolated
.Making tags "share-capable" (changing the
namespaceType
) will regenerate IDs of existing saved objects to ensure that they are unique across all spaces, which is a breaking change.Checklist
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers