Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes missing axis title on discover page #10615

Merged
merged 1 commit into from
Mar 1, 2017

Conversation

ppisljar
Copy link
Member

fixes missing axis title on discover page - fixes #10607

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 v6.0.0 labels Feb 28, 2017
@ppisljar
Copy link
Member Author

jenkins, test this

@weltenwort weltenwort self-requested a review March 1, 2017 14:45
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change of styling intended?

previously:
image

now:
image

It seems to be consistent with the styling in the viz app though, so I guess it's a global change?

@ppisljar
Copy link
Member Author

ppisljar commented Mar 1, 2017

yup, seems styles were changed which affects axis titles everywhere, not something this PR introduced

@ppisljar ppisljar merged commit 67d9188 into elastic:master Mar 1, 2017
elastic-jasper added a commit that referenced this pull request Mar 1, 2017
Backports PR #10615

**Commit 1:**
fix missing axis label

* Original sha: 8308c85
* Authored by ppisljar <[email protected]> on 2017-02-28T10:05:31Z
ppisljar pushed a commit that referenced this pull request Mar 1, 2017
Backports PR #10615

**Commit 1:**
fix missing axis label

* Original sha: 8308c85
* Authored by ppisljar <[email protected]> on 2017-02-28T10:05:31Z
@ppisljar ppisljar deleted the fix/axisTitle branch March 1, 2017 18:30
@ppisljar ppisljar restored the fix/axisTitle branch September 26, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar chart of Discover-page no longer shows X-axis label
3 participants