Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Fix the delete button in the reporting management dashboard #106016

Merged
merged 2 commits into from
Jul 22, 2021
Merged

[Reporting] Fix the delete button in the reporting management dashboard #106016

merged 2 commits into from
Jul 22, 2021

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Jul 16, 2021

Summary

Fix the delete button in the reporting management dashboard.
Resolves #103032.

Checklist

@dokmic dokmic added review (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week v7.15.0 labels Jul 16, 2021
@dokmic dokmic marked this pull request as ready for review July 19, 2021 07:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@dokmic dokmic requested review from tsullivan and jloleysens July 19, 2021 07:07
jloleysens
jloleysens approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dokmic ! I tested and validated locally that the delete button now looks correct ito of width:

Screenshot 2021-07-19 at 15 14 13

I was think we could bring our UI in line with that of the one in ingest pipelines, it's a subtle difference but I think having consistency in our UI/UX is valuable:

singular

Screenshot 2021-07-19 at 15 15 58

multiple

Screenshot 2021-07-19 at 15 15 53

I'll approve to not block you, but I think this would be a nice change to make while we are at it.

@lizozom
Copy link
Contributor

lizozom commented Jul 21, 2021

@elasticmachine merge upstream

@tsullivan
Copy link
Member

I was think we could bring our UI in line with that of the one in ingest pipelines, it's a subtle difference but I think having consistency in our UI/UX is valuable:

Adding a search bar to the reporting table will surely help achieve more consistency!

@dokmic dokmic added the v7.14.1 label Jul 22, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 70.7KB 71.2KB +563.0B

History

  • 💔 Build #140413 failed 3f4e183042c0780e778df6fa29cc125e4e919215
  • 💚 Build #140134 succeeded e46e77f757c0bc1da9d07c65eb25fd844aedd78d
  • 💚 Build #139264 succeeded c73234160acc7bd2845f2d469c8a8f009e2fe1ad
  • 💚 Build #139184 succeeded 286bc00f016b835ba81a42ed469464d5c3cd2df4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic merged commit e952f9a into elastic:master Jul 22, 2021
@dokmic dokmic deleted the bugfix/103032 branch July 22, 2021 18:22
This was referenced Jul 22, 2021
Merged
Merged
dokmic added a commit to dokmic/kibana that referenced this pull request Jul 22, 2021
@dokmic
[Reporting] Fix the delete button in the reporting management dashboa…
49c794b 
…rd (elastic#106016)

* Fix the delete button in the reporting management dashboard
* Update delete button copy for consistency
dokmic added a commit that referenced this pull request Jul 22, 2021
@dokmic
[Reporting] Fix the delete button in the reporting management dashboa…
d1db08c 
…rd (#106016) (#106591)

* Fix the delete button in the reporting management dashboard
* Update delete button copy for consistency
dokmic added a commit that referenced this pull request Jul 22, 2021
@dokmic
[Reporting] Fix the delete button in the reporting management dashboa…
6d85bd9 
…rd (#106016) (#106590)

* Fix the delete button in the reporting management dashboard
* Update delete button copy for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@lizozom lizozom lizozom approved these changes

@tsullivan tsullivan Awaiting requested review from tsullivan

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] Stretched "Delete" button
6 participants
@dokmic @elasticmachine @lizozom @tsullivan @kibanamachine @jloleysens