Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions] Adds error catch to Exceptions toString method #105928

Merged
merged 2 commits into from
Jul 16, 2021
Merged

[Security Solution][Exceptions] Adds error catch to Exceptions toString method #105928

merged 2 commits into from
Jul 16, 2021

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Jul 16, 2021 •
edited
Loading

Summary

Addresses #104442

Fixes bug where if the trusted value within the code_signature field was undefined, an error would throw crashing the app

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Feature:Rule Exceptions Security Solution Detection Rule Exceptions area v7.14.0 v7.15.0 labels Jul 16, 2021
@dplumlee dplumlee self-assigned this Jul 16, 2021
@dplumlee dplumlee requested a review from a team as a code owner July 16, 2021 09:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

yctercero
yctercero approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but can we add a test if there isn't one already to make sure we have a test around the found bug.

@dplumlee dplumlee enabled auto-merge (squash) July 16, 2021 18:41
@dplumlee dplumlee added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 16, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB +146.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@dplumlee dplumlee merged commit fcd515f into elastic:master Jul 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@dplumlee @kibanamachine
[Security Solution][Exceptions] Adds error catch to Exceptions toStri…
2fa316c 
…ng method (elastic#105928)
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@dplumlee @kibanamachine
[Security Solution][Exceptions] Adds error catch to Exceptions toStri…
f5aaf9d 
…ng method (elastic#105928)
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@dplumlee dplumlee deleted the exception-toString-fix branch July 16, 2021 22:00
kibanamachine added a commit that referenced this pull request Jul 16, 2021
@kibanamachine @dplumlee
[Security Solution][Exceptions] Adds error catch to Exceptions toStri…
0e043a5 
…ng method (#105928) (#106030)

Co-authored-by: Davis Plumlee <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 16, 2021
@kibanamachine @dplumlee
[Security Solution][Exceptions] Adds error catch to Exceptions toStri…
8d38dd0 
…ng method (#105928) (#106031)

Co-authored-by: Davis Plumlee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees

@dplumlee dplumlee

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Detection Rule Exceptions area release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dplumlee @elasticmachine @kibanamachine @yctercero