Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Rare anomaly detection job wizard card text #105635

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[ML] Rare anomaly detection job wizard card text #105635

merged 1 commit into from
Jul 15, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 14, 2021 •
edited
Loading

Summary

Related to #100390

This PR further edits the text in the rare job wizard cards.

Screenshot

Before:

image

After:

image

@lcawl lcawl added :ml v7.15.0 v8.0.0 Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes labels Jul 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review July 14, 2021 20:04
@lcawl lcawl requested a review from a team as a code owner July 14, 2021 20:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl requested review from szabosteve, peteharverson and blaklaybul and removed request for blaklaybul July 14, 2021 20:04
@lcawl lcawl mentioned this pull request Jul 14, 2021
Merged
szabosteve
szabosteve approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, LGTM!

peteharverson
peteharverson approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 4f83eae into elastic:master Jul 15, 2021
@lcawl lcawl deleted the rare-card-text branch July 15, 2021 14:23
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 15, 2021
@lcawl
[ML] Rare anomaly detection job wizard card text (elastic#105635)
0e7706b
@lcawl lcawl mentioned this pull request Jul 15, 2021
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 15, 2021
@lcawl
[ML] Rare anomaly detection job wizard card text (elastic#105635)
6242431
@lcawl lcawl mentioned this pull request Jul 15, 2021
Merged
lcawl added a commit that referenced this pull request Jul 15, 2021
@lcawl
[ML] Rare anomaly detection job wizard card text (#105635) (#105772)
5571f11
lcawl added a commit that referenced this pull request Jul 15, 2021
@lcawl
[ML] Rare anomaly detection job wizard card text (#105635) (#105771)
b201d10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabosteve szabosteve szabosteve approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @kibanamachine @elasticmachine @peteharverson @szabosteve