[i18n] Fix some hardcoded translations on Dashboard & Discover #105555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v7.14.1
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
Bamieh
approved these changes
Jul 14, 2021
ThomThomson
approved these changes
Jul 14, 2021
stratoula
approved these changes
Jul 14, 2021
dmlemeshko
added
v7.14.0
auto-backport
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dmlemeshko
added
release_note:fix
v7.15.0
and removed
release_note:skip
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2021
…ic#105555) * [i18n] fix objectType in dashboard/save_search save modal * [i18n] fix objectType in visualize save modal * add translations Co-authored-by: Kibana Machine <[email protected]>
This was referenced Jul 14, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2021
…ic#105555) * [i18n] fix objectType in dashboard/save_search save modal * [i18n] fix objectType in visualize save modal * add translations Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2021
…) (#105631) * [i18n] fix objectType in dashboard/save_search save modal * [i18n] fix objectType in visualize save modal * add translations Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2021
…) (#105632) * [i18n] fix objectType in dashboard/save_search save modal * [i18n] fix objectType in visualize save modal * add translations Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to the SDH: customer is not able to change
dashboardtext to Chinese translation on the saving dialogPR removes hardcoded text from saving modal dialog on dashboard/save search/visualize (it wasn't hardcoded on Lens & Graph)
Checklist
Delete any items that are not applicable to this PR.
- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityRisk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers