Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [KibanaLegacy] Remove unused stuff and make things async if it is easy (#104638) #105208

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[7.x] [KibanaLegacy] Remove unused stuff and make things async if it is easy (#104638) #105208

merged 1 commit into from
Jul 12, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@flash1293 @kibanamachine
@stratoula @estermv
[KibanaLegacy] Remove unused stuff and make things async if it is easy (
786c605 
elastic#104638)

* remove unused stuff and make things async if it is easy

* fix problems

* load bootstrap in monitoring

* load angular bootstrap for saved searches and in  unit tests

* fix vis_type_table tests

* Update x-pack/plugins/monitoring/public/plugin.ts

Co-authored-by: Ester Martí Vilaseca <[email protected]>

* Update x-pack/plugins/monitoring/public/plugin.ts

Co-authored-by: Ester Martí Vilaseca <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Ester Martí Vilaseca <[email protected]>
@kibanamachine kibanamachine enabled auto-merge (squash) July 12, 2021 12:16
@kibanamachine kibanamachine mentioned this pull request Jul 12, 2021
Merged
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 377 378 +1
kibanaLegacy 63 59 -4
total -3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaLegacy 85 62 -23

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 422.3KB 426.6KB +4.3KB
graph 1.1MB 1.1MB -7.0B
kibanaLegacy 112.7KB 122.7KB +10.0KB
visTypeTable 102.4KB 102.4KB +3.0B
total +14.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 93.0KB 93.1KB +126.0B
graph 11.1KB 11.1KB -41.0B
kibanaLegacy 59.2KB 46.2KB -12.9KB
monitoring 45.5KB 45.6KB +67.0B
timelion 9.5KB 9.5KB -41.0B
total -12.8KB
Unknown metric groups

API count

id before after diff
kibanaLegacy 93 66 -27

async chunk count

id before after diff
kibanaLegacy 1 2 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @flash1293

@kibanamachine kibanamachine merged commit 20ce332 into elastic:7.x Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flash1293 flash1293

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibanamachine @flash1293