Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize index data visualizer tests #105204

Closed
wants to merge 4 commits into from
Closed

[ML] Functional tests - stabilize index data visualizer tests #105204

wants to merge 4 commits into from

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jul 12, 2021

Summary

Investigate index data viz test flakiness and fix if needed.

Closes #104576
Closes #105087

@pheyos pheyos self-assigned this Jul 12, 2021
@pheyos
Copy link
Member Author

pheyos commented Jul 12, 2021 •
edited
Loading

Trying to reproduce flakiness in flaky test runner jobs:

  • 1709 ... no failure in 50 runs ✔️
  • 1711 ... no failure in 50 runs ✔️
  • 1713 ... no failure in 50 runs ✔️

@pheyos pheyos changed the title Debug - only run index data viz tests [ML] Functional tests - stabilize index data visualizer tests Jul 12, 2021
@pheyos
Copy link
Member Author

pheyos commented Jul 13, 2021 •
edited
Loading

Trying again to reproduce flakiness in flaky test runner jobs (this time with all test suites enabled in the ciGroup):

  • 1718 ... no failure in 50 runs ✔️
  • 1723 ... no data visualizer failure in 50 runs ✔️ (just one unrelated feature importance failure)

@spalger spalger mentioned this pull request Jul 15, 2021
Closed
@pheyos
Copy link
Member Author

pheyos commented Jul 16, 2021

Re-enabled the test suite and trying again to reproduce flakiness in flaky test runner jobs:

@pheyos pheyos mentioned this pull request Jul 16, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos
Copy link
Member Author

pheyos commented Jul 16, 2021

After some more investigation it looks like a race condition bug, that I've reported in #105951.
Tests should be re-enabled as part of the fix PR, so I'm closing this one.

@pheyos pheyos closed this Jul 16, 2021
@pheyos pheyos deleted the stabilize_data_viz_tests branch September 1, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pheyos pheyos

Labels
:ml test_ui_functional
Projects
None yet
Milestone
No milestone
2 participants
@pheyos @kibanamachine