Replace cmd with bash as EuiCodeBlock language #105065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd is no longer supported by 3rd party library used by EuiCodeBlock
yakhinvadim
added
auto-backport
scottybollinger
approved these changes
Jul 9, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
cmd is no longer supported by 3rd party library used by EuiCodeBlock
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
cmd is no longer supported by 3rd party library used by EuiCodeBlock
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
cmd is no longer supported by 3rd party library used by EuiCodeBlock Co-authored-by: Vadim Yakhin <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
cmd is no longer supported by 3rd party library used by EuiCodeBlock Co-authored-by: Vadim Yakhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/workplace-search-team/issues/1844
Replaced cmd with bash as EuiCodeBlock language.
cmdis no longer supported by 3rd party library used by EuiCodeBlock.Before:
Screen.Cast.2021-07-09.at.10.53.34.AM.mp4
After:
Screen.Cast.2021-07-09.at.10.44.30.AM.mp4
I don't think we need a test for this in our plugin since the correct language prop should be verified in EUI. There's already an issue for that: elastic/eui#4849