Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Updates URLs in documentation link service #105011

Merged
merged 6 commits into from
Jul 13, 2021
Merged

[ML] Updates URLs in documentation link service #105011

merged 6 commits into from
Jul 13, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 9, 2021 •
edited
Loading

Summary

Related to elastic/stack-docs#1739 and elastic/stack-docs#1750

This PR addresses the following broken links:

18:39:00 INFO:build_docs: Kibana [master]: src/core/public/doc_links/doc_links_service.ts contains broken links to:
18:39:00 INFO:build_docs: - en/machine-learning/master/create-jobs.html#bucket-span
18:39:00 INFO:build_docs: - en/machine-learning/master/create-jobs.html#cardinality
18:39:00 INFO:build_docs: - en/machine-learning/master/create-jobs.html#detectors
18:39:00 INFO:build_docs: - en/machine-learning/master/create-jobs.html#job-tips
18:39:00 INFO:build_docs: - en/machine-learning/master/create-jobs.html#model-memory-limits

It also updates links to the machine learning conceptual pages, which have moved within the Machine Learning guide.

@lcawl lcawl mentioned this pull request Jul 9, 2021
Closed
@lcawl lcawl marked this pull request as ready for review July 9, 2021 18:02
@lcawl lcawl requested review from a team as code owners July 9, 2021 18:02
@lcawl lcawl added :ml backport:skip This commit does not require backporting v8.0.0 labels Jul 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Jul 9, 2021
@lcawl lcawl mentioned this pull request Jul 9, 2021
Closed
@lcawl
Copy link
Contributor Author

lcawl commented Jul 9, 2021

@elasticmachine merge upstream

@lcawl
Copy link
Contributor Author

lcawl commented Jul 12, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 420.5KB 420.7KB +216.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit d5c5fb7 into elastic:master Jul 13, 2021
@lcawl lcawl deleted the job-tip-links branch July 13, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @elasticmachine @kibanamachine @pgayvallet @peteharverson