Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding es version field support #104870

Merged
merged 4 commits into from
Jul 22, 2021
Merged

adding es version field support #104870

merged 4 commits into from
Jul 22, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jul 8, 2021

Summary

adding es version field support

@ppisljar ppisljar requested a review from a team as a code owner July 8, 2021 13:35
@ppisljar
Copy link
Member Author

ppisljar commented Jul 8, 2021

@elasticmachine merge upstream

@timroes timroes added v8.0.0 and removed 8.0.0 labels Jul 8, 2021
vadimkibana
vadimkibana approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@vadimkibana vadimkibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked locally on Mac/Chrome.

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 837.7KB 837.7KB +49.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 63ffc9f into elastic:master Jul 22, 2021
@ppisljar ppisljar added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 22, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2021
@ppisljar @kibanamachine
adding es version field support (elastic#104870)
117f69d
@kibanamachine kibanamachine mentioned this pull request Jul 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 22, 2021
@kibanamachine @ppisljar
adding es version field support (#104870) (#106528)
7098969 
Co-authored-by: Peter Pisljar <[email protected]>
ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 3, 2021
@ppisljar
adding es version field support (elastic#104870)
56fd78e 
(cherry picked from commit 63ffc9f)
@bhavyarm
Copy link
Contributor

@ppisljar how do I test this please? Thanks

@ppisljar
Copy link
Member Author

create an index with a version field type and create matching index pattern in kibana. you should see the field mapped as version type in index pattern management page. going to discover you should be able to add queries like myversionfield > 7.11.0 AND myversionfield < 7.12.2 and get correct results

@KOTungseth KOTungseth added Feature: Index Patterns Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Sep 1, 2021
@Dosant Dosant mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:enhancement v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ppisljar @kibanamachine @bhavyarm @vadimkibana @mattkime @timroes @KOTungseth