[Canvas] Expression progress #104457

Kuznietsov · 2021-07-06T14:05:25Z

Completes a part of #101377.

At this PR progress expression is extracted from the canvas plugin and set up as a separate plugin.

List of required changes to be done:

Extract progress expression from canvas to a separate plugin.
Move it to ts and React.
Add Storybook for the progress expression renderer.
Remove legacy expression from canvas plugin
Add fixes of errors

Testing Notes

This moves the progress expression function to a standalone plugin and refactors the code. To test, just test that the progress expression in canvas continues to work as expected.

elasticmachine · 2021-07-27T09:37:19Z

Pinging @elastic/kibana-presentation (Team:Presentation)

crob611

Everything looks good. Need to figure out those class names that start with "canvas"

crob611 · 2021-07-27T20:50:08Z

src/plugins/presentation_util/common/lib/utils/get_id.ts

@@ -1,8 +1,9 @@
 /*
 * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
 * or more contributor license agreements. Licensed under the Elastic License
- * 2.0; you may not use this file except in compliance with the Elastic License
- * 2.0.
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except


What caused the need to move this file to pres_util?

I'd like to try to keep presentation_util as only things that are really presentation related. Can we just inline the id generation on the SVG?

Updated PR based on your nit.

crob611 · 2021-07-27T21:00:38Z

src/plugins/expression_shape/public/components/progress/progress_component.tsx

+  const BarProgress = shapeData.shapeType ? getShapeContentElement(shapeData.shapeType) : null;
+
+  const shapeContentAttributes = {
+    className: 'canvasProgress__background',


We need to get rid of all these canvas_ prefixed class names since this is not strictly canvas anymore. Are they even used for anything at this point? Can you double check on that?

Removed this canvas* classes. According to the code, it is not necessary, but, possibly, some tests were using it. After passing the CI we'll see)))

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

Kuznietsov · 2021-07-30T06:12:34Z

@elasticmachine merge upstream

Kuznietsov · 2021-07-30T08:18:15Z

@elasticmachine merge upstream

Kuznietsov · 2021-08-02T06:03:06Z

@elasticmachine merge upstream

Kuznietsov · 2021-08-02T13:01:45Z

@elasticmachine merge upstream

crob611

Looks good to go 👍

kibanamachine · 2021-08-04T08:36:19Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 104457

* Added `expression_progress` plugin. Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-optimizer/limits.yml

* [Canvas] Expression progress (#104457) * Added `expression_progress` plugin. Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-optimizer/limits.yml * Update limits.yml

* Added `expression_progress` plugin. Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-08-19T20:12:55Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`canvas`	1057	1045	-12
`expressionShape`	42	61	+19
total			+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.6MB	1.6MB	-10.1KB
`expressionShape`	7.3KB	23.5KB	+16.2KB
total			+6.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressionShape`	17.3KB	27.5KB	+10.2KB

Unknown metric groups

API count

id	before	after	diff
`expressionShape`	90	141	+51

API count missing comments

id	before	after	diff
`expressionShape`	90	141	+51

async chunk count

id	before	after	diff
`expressionShape`	2	4	+2

References to deprecated APIs

id	before	after	diff
`canvas`	36	34	-2

History

💚 Build #142856 succeeded fc618e1
💚 Build #142283 succeeded 3e4927a
💔 Build #142180 failed 438fada
💚 Build #141874 succeeded 0cea447
💔 Build #141854 failed 3ca44a6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

Kuznietsov requested a review from alexwizp July 6, 2021 14:05

Kuznietsov self-assigned this Jul 14, 2021

Kuznietsov removed the WIP Work in progress label Jul 14, 2021

Kuznietsov changed the title ~~[WIP][Canvas] Expression progress~~ [Canvas] Expression progress Jul 14, 2021

Kuznietsov mentioned this pull request Jul 16, 2021

[Canvas] Expression shape #103219

Merged

5 tasks

Added expression_progress plugin.

9d7f2d6

Kuznietsov force-pushed the expression_progress branch from 05f87a2 to 9d7f2d6 Compare July 27, 2021 07:55

Kuznietsov added 6 commits July 27, 2021 11:14

Fixed import of progress function/renderer.

ce04ca5

Fixed names of ref.

c640ae4

Fixed types of refs.

5161986

Fixed if statement form.

c9d1ef7

Fixed legacy merge mistakes.

532ed8b

Fixed if statements.

34792df

Kuznietsov requested a review from crob611 July 27, 2021 09:37

Kuznietsov marked this pull request as ready for review July 27, 2021 09:37

Kuznietsov requested review from a team as code owners July 27, 2021 09:37

jbudz approved these changes Jul 27, 2021

View reviewed changes

crob611 suggested changes Jul 27, 2021

View reviewed changes

Merge branch 'master' into expression_progress

43b28e3

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

Removed canvas* classes.

7d43909

Kuznietsov requested a review from crob611 July 28, 2021 13:49

Moved getId back to canvas and removed from pres_util.

19917d4

Merge branch 'master' into expression_progress

3ca44a6

Merge branch 'master' into expression_progress

0cea447

Merge branch 'master' into expression_progress

438fada

Merge branch 'master' into expression_progress

3e4927a

crob611 approved these changes Aug 3, 2021

View reviewed changes

Merge branch 'master' into expression_progress

fc618e1

Kuznietsov merged commit dbab7d9 into elastic:master Aug 4, 2021

Kuznietsov mentioned this pull request Aug 4, 2021

[7.x] [Canvas] Expression progress (#104457) #107620

Merged

Kuznietsov added a commit to Kuznietsov/kibana that referenced this pull request Aug 4, 2021

[Canvas] Expression progress (elastic#104457)

6a3a7c5

* Added `expression_progress` plugin. Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-optimizer/limits.yml

streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021

[Canvas] Expression progress (elastic#104457)

6286954

* Added `expression_progress` plugin. Co-authored-by: Kibana Machine <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] Expression progress #104457

[Canvas] Expression progress #104457

Kuznietsov commented Jul 6, 2021 •

edited by crob611

Loading

elasticmachine commented Jul 27, 2021

crob611 left a comment

crob611 Jul 27, 2021

Kuznietsov Jul 28, 2021 •

edited

Loading

crob611 Jul 28, 2021

Kuznietsov Jul 29, 2021

crob611 Jul 27, 2021

Kuznietsov Jul 28, 2021

Kuznietsov commented Jul 30, 2021

Kuznietsov commented Jul 30, 2021

Kuznietsov commented Aug 2, 2021

Kuznietsov commented Aug 2, 2021

crob611 left a comment

kibanamachine commented Aug 4, 2021

kibanamachine commented Aug 19, 2021

API count

API count missing comments

async chunk count

References to deprecated APIs

[Canvas] Expression progress #104457

[Canvas] Expression progress #104457

Conversation

Kuznietsov commented Jul 6, 2021 • edited by crob611 Loading

Testing Notes

elasticmachine commented Jul 27, 2021

crob611 left a comment

Choose a reason for hiding this comment

crob611 Jul 27, 2021

Choose a reason for hiding this comment

Kuznietsov Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

crob611 Jul 28, 2021

Choose a reason for hiding this comment

Kuznietsov Jul 29, 2021

Choose a reason for hiding this comment

crob611 Jul 27, 2021

Choose a reason for hiding this comment

Kuznietsov Jul 28, 2021

Choose a reason for hiding this comment

Kuznietsov commented Jul 30, 2021

Kuznietsov commented Jul 30, 2021

Kuznietsov commented Aug 2, 2021

Kuznietsov commented Aug 2, 2021

crob611 left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 4, 2021

💔 Backport failed

kibanamachine commented Aug 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

API count missing comments

async chunk count

References to deprecated APIs

History

Kuznietsov commented Jul 6, 2021 •

edited by crob611

Loading

Kuznietsov Jul 28, 2021 •

edited

Loading