Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix powershell command to add fleet server #104342

Merged
merged 2 commits into from
Jul 6, 2021
Merged

[Fleet] Fix powershell command to add fleet server #104342

merged 2 commits into from
Jul 6, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 5, 2021

Summary

In #103550 we added newline in the commands to run Fleet server on premise, the newline separator on windows is not backslash but a backtick that PR fix that

UI Changes

Screen Shot 2021-07-05 at 2 30 08 PM

Screen Shot 2021-07-05 at 2 25 30 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 5, 2021
@nchaulet nchaulet self-assigned this Jul 5, 2021
@nchaulet nchaulet requested a review from a team as a code owner July 5, 2021 18:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet force-pushed the fix-104273-powershell-fleetserver branch from 23d2d0f to fadca47 Compare July 5, 2021 18:32
@nchaulet
Copy link
Member Author

nchaulet commented Jul 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 715.5KB 715.7KB +195.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

kpollich
kpollich approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet nchaulet merged commit 75187b6 into elastic:master Jul 6, 2021
@nchaulet nchaulet deleted the fix-104273-powershell-fleetserver branch July 6, 2021 13:16
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@nchaulet @kibanamachine
[Fleet] Fix powershell command to add fleet server (elastic#104342)
c302bcf
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 6, 2021
@nchaulet @kibanamachine
[Fleet] Fix powershell command to add fleet server (elastic#104342)
daa36d7
@kibanamachine kibanamachine mentioned this pull request Jul 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine @nchaulet
[Fleet] Fix powershell command to add fleet server (#104342) (#104439)
18c8644 
Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine @nchaulet
[Fleet] Fix powershell command to add fleet server (#104342) (#104441)
e27235c 
Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nchaulet @elasticmachine @kibanamachine @kpollich