Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Expression image #104318

Merged
merged 7 commits into from
Jul 26, 2021
Merged

[Canvas] Expression image #104318

merged 7 commits into from
Jul 26, 2021

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Jul 5, 2021 •
edited by crob611
Loading

Completes a part of #101377.

At this PR image expression is extracted from the canvas plugin and set up as a separate plugin.

List of required changes to be done:

  • Extract image expression from canvas to a separate plugin.
  • Move it to ts and React.
  • Add Storybook for the image expression renderer.
  • Remove legacy expression from canvas plugin
  • Add fixes of errors

Testing Notes

This moves the image expression function to a standalone plugin and refactors the code. To test, just test that the image expression in canvas continues to work as expected.

@Kuznietsov Kuznietsov added WIP Work in progress Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas labels Jul 5, 2021
@Kuznietsov Kuznietsov requested a review from alexwizp July 5, 2021 15:08
@Kuznietsov Kuznietsov changed the title [Canvas] Expression image [WIP][Canvas] Expression image Jul 5, 2021
@Kuznietsov Kuznietsov added auto-backport Deprecated - use backport:version if exact versions are needed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:weeks release_note:enhancement v7.15.0 v8.0.0 and removed WIP Work in progress labels Jul 6, 2021
@Kuznietsov Kuznietsov changed the title [WIP][Canvas] Expression image [Canvas] Expression image Jul 6, 2021
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov requested a review from crob611 July 23, 2021 09:46
@Kuznietsov Kuznietsov self-assigned this Jul 23, 2021
@Kuznietsov Kuznietsov marked this pull request as ready for review July 23, 2021 09:46
@Kuznietsov Kuznietsov requested review from a team as code owners July 23, 2021 09:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Kuznietsov
Copy link
Contributor Author

@tylersmalley, thanks for your review and approval )

crob611
crob611 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov merged commit 3027999 into elastic:master Jul 26, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 104318

Kuznietsov added a commit to Kuznietsov/kibana that referenced this pull request Jul 26, 2021
@Kuznietsov
[Canvas] Expression image (elastic#104318)
0193d53 
* Added `expression_image` plugin.

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@Kuznietsov Kuznietsov mentioned this pull request Jul 26, 2021
Merged
Kuznietsov added a commit to Kuznietsov/kibana that referenced this pull request Jul 26, 2021
@Kuznietsov @kibanamachine
[Canvas] Expression image (elastic#104318)
2ee76bd 
* Added `expression_image` plugin.

Co-authored-by: Kibana Machine <[email protected]>
Kuznietsov added a commit that referenced this pull request Jul 26, 2021
@Kuznietsov
[Canvas] Expression image (#104318) (#106683)
daa98ee 
* Added `expression_image` plugin.

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@Kuznietsov @kibanamachine @vadimkibana
[Canvas] Expression image (elastic#104318)
3e1f372 
* Added `expression_image` plugin.

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 999 996 -3
expressionImage - 12 +12
total +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.5MB 1.5MB -4.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 24.5KB 24.7KB +242.0B
expressionImage - 7.2KB +7.2KB
total +7.4KB
Unknown metric groups

API count

id before after diff
expressionImage - 4 +4

API count missing comments

id before after diff
expressionImage - 4 +4

Non-exported public API item count

id before after diff
expressionImage - 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @elasticmachine @kibanamachine @tylersmalley @crob611