Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas] Fix Expressions button alignment #104228

Merged
merged 1 commit into from
Jul 2, 2021
Merged

[canvas] Fix Expressions button alignment #104228

merged 1 commit into from
Jul 2, 2021

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Jul 1, 2021 •
edited
Loading

Summary

Blames to #103601

I missed a grow param when I fixed the toolbar.

Screen Shot 2021-07-01 at 6 09 39 PM

@clintandrewhall clintandrewhall added bug Fixes for quality problems that affect the customer experience review regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas v7.14.0 v7.15.0 labels Jul 1, 2021
@clintandrewhall clintandrewhall requested a review from a team as a code owner July 1, 2021 22:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@clintandrewhall clintandrewhall added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 1, 2021
@clintandrewhall clintandrewhall enabled auto-merge (squash) July 1, 2021 22:10
cqliu1
cqliu1 approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB -5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 5bac6b2 into elastic:master Jul 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 2, 2021
@clintandrewhall @kibanamachine
[canvas] Fix Expressions button alignment (elastic#104228)
e491f69
@kibanamachine kibanamachine mentioned this pull request Jul 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 2, 2021
@clintandrewhall @kibanamachine
[canvas] Fix Expressions button alignment (elastic#104228)
3a822b6
@kibanamachine kibanamachine mentioned this pull request Jul 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 2, 2021
@kibanamachine @clintandrewhall
[canvas] Fix Expressions button alignment (#104228) (#104237)
d7a633d 
Co-authored-by: Clint Andrew Hall <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 6, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Jul 6, 2021
@kibanamachine @clintandrewhall
[canvas] Fix Expressions button alignment (#104228) (#104238)
015995e 
Co-authored-by: Clint Andrew Hall <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 6, 2021
@clintandrewhall clintandrewhall deleted the canvas/fix-button branch July 9, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqliu1 cqliu1 cqliu1 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort regression release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clintandrewhall @elasticmachine @kibanamachine @cqliu1