[Integrations UI] Search integrations for all substrings + don't search on description #104099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
v8.0.0
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
added
the
release_note:skip
jen-huang
approved these changes
Jul 1, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 1, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 1, 2021
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2021
…104099) (#104128) Co-authored-by: Kyle Pollich <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2021
…104099) (#104127) Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #96462
Update package search on browse/manage pages in Integrations UI to search only on name + title (not description), and updates search strategy to JS Search's "All Substrings" strategy: https://www.npmjs.com/package/js-search#configuring-the-index-strategy.
This makes the package search function nearly identically to the now-deprecated "add package step" component that was removed in #101714. If we want this to be completely identical to that previous implementation, we can remove the "name" field from the local search index as well and only search on the "title".
Screen Recording