[Cloud] Fix sessions stitching across domains #103964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Jun 30, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2021
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2021
Co-authored-by: Josh Dover <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2021
Co-authored-by: Josh Dover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After some manual integration testing across the Cloud UI and Kibana UI, we have found that to make sessions merging across domains work properly, the
identifycall must happen in the same tick when the session recording script is initialized.This change slightly delays how fast we initialize the session recording script, but in my testing on Cloud staging this should only delay the recording in the 100ms range. Since this code executed before any UI should be shown anyways, this should be acceptable.
I ran the functional tests that are not yet enabled on CI and everything passed.
Checklist
Delete any items that are not applicable to this PR.