[paths] Add default lookup for kibana.yml at /etc/kibana #103934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `(KBN|KIBANA)_PATH_CONF` was introduced, we removed the fallback lookup to `/etc/kibana/kibana.yml` in elastic#67433. This environment variable was added to `/etc/default/kibana` and made available, scoped to the Kibana service for deb and rpm packages. This environment setting, however, is not available when running binaries directly and caused the regression noted in This re-adds a fallback lookup to `/etc/kibana/kibana.yml` when searching for a kibana.yml configuration. Testing 1) Install a .deb or .rpm package 2) `sudo -u kibana /usr/share/bin/kibana --version` Closes elastic#101249
jbudz
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
changed the title
|
I'll attach builds for testing for in ~an hour. edit: |
jbudz
added
the
auto-backport
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
…105009) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
…105008) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
(KBN|KIBANA)_PATH_CONFwas introduced, we removed the fallback lookup to/etc/kibana/kibana.ymlin #67433. This environment variable was addedto
/etc/default/kibanaand made available, scoped to the Kibana servicefor deb and rpm packages. This environment setting, however, is not available
when running binaries directly and caused the regression noted in #101249.
This re-adds a fallback lookup to
/etc/kibana/kibana.ymlwhensearching for a kibana.yml configuration.
Testing
sudo -u kibana /usr/share/bin/kibana --versionCloses #101249