Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. #103725

Merged

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Jun 29, 2021

Resolves #101521

Summary

Current PR fixed alerting docs formatting issues and added a missing documentation for the rules statuses.

Link for testing https://kibana_103725.docs-preview.app.elstc.co/guide/en/kibana/master/alerting-getting-started.html

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v7.14.0 labels Jun 29, 2021
@YulNaumenko YulNaumenko self-assigned this Jun 29, 2021
@YulNaumenko YulNaumenko requested a review from a team as a code owner June 29, 2021 17:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko requested a review from gchaps June 30, 2021 10:09
@YulNaumenko
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

@YulNaumenko YulNaumenko requested a review from ymao1 June 30, 2021 17:26
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YulNaumenko YulNaumenko merged commit bd0f058 into elastic:master Jun 30, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jun 30, 2021
…Added docs about rules statuses. (elastic#103725)

* [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses.

* Apply suggestions from code review

Co-authored-by: ymao1 <[email protected]>

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* fixed due to the comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit that referenced this pull request Jul 1, 2021
…Added docs about rules statuses. (#103725) (#103953)

* [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses.

* Apply suggestions from code review

Co-authored-by: ymao1 <[email protected]>

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* fixed due to the comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
Co-authored-by: gchaps <[email protected]>
@spalger spalger added the v7.15.0 label Jul 7, 2021
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 7, 2021
…Added docs about rules statuses. (elastic#103725)

* [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses.

* Apply suggestions from code review

Co-authored-by: ymao1 <[email protected]>

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* fixed due to the comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
Co-authored-by: gchaps <[email protected]>
spalger pushed a commit that referenced this pull request Jul 7, 2021
…Added docs about rules statuses. (#103725) (#104715)

* [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses.

* Apply suggestions from code review

Co-authored-by: ymao1 <[email protected]>

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

* fixed due to the comments

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Yuliia Naumenko <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Kibana Alert Statuses
6 participants