-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. #103725
Merged
YulNaumenko
merged 5 commits into
elastic:master
from
YulNaumenko:alerting-docs-formatting-issues
Jun 30, 2021
Merged
[Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. #103725
YulNaumenko
merged 5 commits into
elastic:master
from
YulNaumenko:alerting-docs-formatting-issues
Jun 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added docs about rules statuses.
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
@elasticmachine merge upstream |
ymao1
reviewed
Jun 30, 2021
Co-authored-by: ymao1 <[email protected]>
gchaps
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Co-authored-by: gchaps <[email protected]>
ymao1
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Jun 30, 2021
…Added docs about rules statuses. (elastic#103725) * [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. * Apply suggestions from code review Co-authored-by: ymao1 <[email protected]> * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * fixed due to the comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: gchaps <[email protected]>
YulNaumenko
added a commit
that referenced
this pull request
Jul 1, 2021
…Added docs about rules statuses. (#103725) (#103953) * [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. * Apply suggestions from code review Co-authored-by: ymao1 <[email protected]> * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * fixed due to the comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: gchaps <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: gchaps <[email protected]>
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 7, 2021
…Added docs about rules statuses. (elastic#103725) * [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. * Apply suggestions from code review Co-authored-by: ymao1 <[email protected]> * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * fixed due to the comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: gchaps <[email protected]>
spalger
pushed a commit
that referenced
this pull request
Jul 7, 2021
…Added docs about rules statuses. (#103725) (#104715) * [Alerting][Docs] Fixed formatting issues for alerting documentation. Added docs about rules statuses. * Apply suggestions from code review Co-authored-by: ymao1 <[email protected]> * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * fixed due to the comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: gchaps <[email protected]> Co-authored-by: Yuliia Naumenko <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: gchaps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Feature:Alerting
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v7.14.0
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #101521
Summary
Current PR fixed alerting docs formatting issues and added a missing documentation for the rules statuses.
Link for testing https://kibana_103725.docs-preview.app.elstc.co/guide/en/kibana/master/alerting-getting-started.html