Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integrations UI] Allow for versionless integration details urls #103484

Merged

Conversation

kpollich
Copy link
Member

Summary

Default to either the installed version of an integration or the latest available version based on installation status when a version is not included in the integration details URL.

e.g. http://localhost:5601/app/integrations#/detail/nginx/overview

Note that when landing on a versionless details page, the tabs, links, etc throughout the page will still link to versioned URL's, this PR simply adds the "fallback" functionality to allow other Kibana apps to potentially "hard code" links to integrations without fetching package/version data to generate versioned URL's.

Show Screenshots
Screenshot Notes
Screen Shot 2021-06-28 at 9 12 28 AM When an outdated version of an integration is installed and no version is provided in the URL, we show the installed version
Screen Shot 2021-06-28 at 9 13 29 AM When an up-to-date version of an integration is installed and no version is provided in the URL, we show the installed version
Screen Shot 2021-06-28 at 9 13 59 AM When an integration is not installed and no version is provided in the URL, we show the latest available version

Closes #93393

Checklist

Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes elastic#93393
@kpollich kpollich added release_note:enhancement v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 28, 2021
@kpollich kpollich requested a review from a team as a code owner June 28, 2021 13:59
@kpollich kpollich self-assigned this Jun 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 4e20645 into elastic:master Jun 28, 2021
@kpollich kpollich deleted the 93393-versionless-integration-urls branch June 28, 2021 19:53
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 28, 2021
Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes elastic#93393
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 28, 2021
Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes #93393

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Allow to link to Integration without specifying the concrete version
4 participants