-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Implementation of RuleExecutionLogClient #103463
Conversation
7c33cde
to
34882c0
Compare
1387e22
to
1f0f182
Compare
d6cd759
to
4fc4706
Compare
4fc4706
to
92ab22f
Compare
9d097cb
to
cb401fa
Compare
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
9e53e3b
to
2e5ea8c
Compare
2e5ea8c
to
d319d63
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
Non-exported public API item count
History
To update your PR or re-run it, just comment with: cc @xcrzx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to be merged!
I left some comments, but none of them are anything significant to block this PR. Still, let's quickly go through them and decide, which of them could be addressed in a follow-up PR.
🚀 🎉
x-pack/plugins/security_solution/common/detection_engine/schemas/common/schemas.ts
Show resolved
Hide resolved
...ity_solution/server/lib/detection_engine/rule_execution_log/adapters/rule_registry_dapter.ts
Show resolved
Hide resolved
...ty_solution/server/lib/detection_engine/rule_execution_log/adapters/saved_objects_adapter.ts
Show resolved
Hide resolved
...ity_solution/server/lib/detection_engine/rule_execution_log/adapters/rule_registry_dapter.ts
Show resolved
Hide resolved
...ecurity_solution/server/lib/detection_engine/rule_execution_log/rule_execution_log_client.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/detection_engine/rules/types.ts
Show resolved
Hide resolved
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Dmitry Shevchenko <[email protected]>
Addresses: #106461, #106466
Summary
This PR adds rule execution log implementation build on top of
rule_registry
.How to test this implementation
echo "xpack.securitySolution.enableExperimental: ['ruleRegistryEnabled']" >> ./config/kibana.dev.yml
echo "xpack.ruleRegistry.write.enabled: true" >> ./config/kibana.dev.yml
./x-pack/plugins/security_solution/server/lib/detection_engine/reference_rules/scripts/create_reference_rule_query.sh
It creates a rule that generates 10 alerts every minute or so. The created rule is not visible in our UI and is not accessible through most of our API endpoints. But, we can fetch rule execution logs using the
setection_engine/rules/_find_statuses
endpoint.The output could look like this:
These are logs written by the
RuleExecutionLogClient
during the rule execution.Design
Integration Phase 1
Integration Phase 2
Integration Phase 3
TODO