[Security Solution] Add Windows and macOs option to dropdown for creating Exceptions from scratch #103404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlog
added
v8.0.0
Team:Defend Workflows
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kevinlog
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2021
…ting Exceptions from scratch (elastic#103404)
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 28, 2021
…ting Exceptions from scratch (#103404) (#103529) Co-authored-by: Kevin Logan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a dropdown option for OS in Exceptions to allow users to create an Exception for both Mac and Windows in one go. This is meant to preserve previous functionality where creating Exceptions from scratch always added the Exception to both Mac and Windows.
It addresses #102613
New Dropdown options:
Selecting Windows and macOs properly gives user the correct
*.caselessoptionsSaved Exception for Mac and Windows:
Editing an Exception for Mac and Windows:
Linux only options still has options without
*.caseless:Creating Exceptions from Alerts still works as expected:
Checklist
Delete any items that are not applicable to this PR.