Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Dashboard locator (#102854) #103388

Merged
merged 1 commit into from
Jun 25, 2021
Merged

[7.x] Dashboard locator (#102854) #103388

merged 1 commit into from
Jun 25, 2021

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

* Add dashboard locator

* feat: 🎸 expose dashboard locator from dashboard plugin

* Use dashboard locator in dashboard drilldown

* Add tests for dashboard locator

* Fix dashboard drilldown tests after refactor

* Deprecate dashboard URL generator

* Fix TypeScript errors in exmaple plugin

* Use correct type for dashboard locator

* refactor: 💡 change "route" attribute to "path"

* chore: 🤖 remove unused bundle

Co-authored-by: Vadim Kibana <[email protected]>
Co-authored-by: Vadim Kibana <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@streamich streamich enabled auto-merge (squash) June 25, 2021 05:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 265 266 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 133 137 +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 325.4KB 328.0KB +2.6KB
dashboardEnhanced 24.9KB 24.7KB -195.0B
total +2.4KB
Unknown metric groups

API count

id before after diff
dashboard 145 160 +15

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit bfb66d0 into elastic:7.x Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants