Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching interpreter package from peg.js to peggy #103169

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jun 23, 2021

Summary

Moves interpreter grammar from peg.js to peggy

resolves #97504

@ppisljar ppisljar requested a review from a team as a code owner June 23, 2021 19:37
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jun 23, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB -134.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 521.8KB 521.7KB -134.0B
expressions 210.2KB 210.0KB -134.0B
total -268.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@ppisljar ppisljar added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jun 24, 2021
@ppisljar ppisljar merged commit 9a1f5a4 into elastic:master Jun 24, 2021
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jun 27, 2021
ppisljar added a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expressions][kql] Migrate from PEG.js to new "Peggy" fork.
4 participants