[Fleet] Fix staleness bug in "Add agent" flyout #103095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored naming
… state sync issues
jloleysens
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
jloleysens
commented
Jun 23, 2021
|
|
||
| setEnrollmentAPIKeys(enrollmentAPIKeysResponse); | ||
| // Default to the first the first enrollment key if there is one. | ||
| onKeyChange(enrollmentAPIKeysResponse[0]?.id); |
There was a problem hiding this comment.
This line is the fix for the bug in the linked issue.
kpollich
approved these changes
Jun 23, 2021
| ); | ||
|
|
||
| setEnrollmentAPIKeys(enrollmentAPIKeysResponse); | ||
| // Default to the first the first enrollment key if there is one. |
There was a problem hiding this comment.
Comment has a typo. "The first" appears twice.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2021
* * Fix stale enrollment api token bug * Refactored naming * raise the state of the selected enrollment api key to parent to avoid state sync issues * removed consts for onKeyChange and selectedApiKeyId * fix typo Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 24, 2021
* * Fix stale enrollment api token bug * Refactored naming * raise the state of the selected enrollment api key to parent to avoid state sync issues * removed consts for onKeyChange and selectedApiKeyId * fix typo Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
|
Hi @EricDavisX
Build details: Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #102863. Looks like a regression from #101576.
How to test
See the linked issue for more details.
To reviewers
This contribution refactors how some of the state is managed in the "Add agent" flyout. Currently the state management uses callbacks only with nested child state values that need to call the callbacks to keep the parent component's state in sync. This can lead to staleness bugs if we refactor these components, as was recently done, and do not propagate state correctly back up to the parent (single source of truth).
Happy to leave these changes out though if it introduces too much volatility since it is another refactor!
Checklist
For now, manual testing is done per the PR description.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers