Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home & Kibana Overview Page Template Update #103003

Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
844aab8
apply page template comp to kibana overview
MichaelMarcialis Jun 21, 2021
e412b22
apply page template comp to home page
MichaelMarcialis Jun 21, 2021
7744db2
clean up
MichaelMarcialis Jun 21, 2021
a436aad
strip null actions from array
MichaelMarcialis Jun 21, 2021
5af064c
update snapshot and remove outdated import
MichaelMarcialis Jun 22, 2021
ac2c916
fix tests and update snapshots
MichaelMarcialis Jun 22, 2021
5336fc9
update tests and snapshots
MichaelMarcialis Jun 22, 2021
c1637ba
Merge branch 'master' of github.com:elastic/kibana into home-overview…
MichaelMarcialis Jun 22, 2021
1d665ba
Switch to KibanaPageTemplate; use template=“empty”
MichaelMarcialis Jun 22, 2021
880e04d
update snapshots
MichaelMarcialis Jun 22, 2021
ae3a55b
Merge branch 'master' of github.com:elastic/kibana into home-overview…
MichaelMarcialis Jun 23, 2021
5625820
make `EuiCard` transparent
MichaelMarcialis Jun 23, 2021
6e3dbaa
updated snapshots
MichaelMarcialis Jun 23, 2021
e17a9b6
restored data-test-subj="homeApp"
MichaelMarcialis Jun 23, 2021
662401a
Merge branch 'master' of github.com:elastic/kibana into home-overview…
MichaelMarcialis Jun 23, 2021
1523a41
Merge branch 'master' of github.com:elastic/kibana into home-overview…
MichaelMarcialis Jun 24, 2021
b646cc0
Merge branch 'master' of github.com:elastic/kibana into home-overview…
MichaelMarcialis Jun 24, 2021
a47bb96
change scope of styles
MichaelMarcialis Jun 24, 2021
5f21ff0
update snapshots
MichaelMarcialis Jun 24, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to KibanaPageTemplate; use template=“empty”
  • Loading branch information
MichaelMarcialis committed Jun 22, 2021
commit 1d665ba17d1f087ff1c561989692fee08503373b
4 changes: 0 additions & 4 deletions src/plugins/home/public/application/components/_home.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
.homPageHeader--hasOverlap {
padding-bottom: ($euiSizeL * 2);
}

.homData--expanded {
flex-direction: column;

Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
.homSolutions {
margin-top: -(($euiSizeL * 2) + $euiSizeM);
}

.homSolutions__content {
min-height: $euiSize * 16;

9 changes: 5 additions & 4 deletions src/plugins/home/public/application/components/home.js
Original file line number Diff line number Diff line change
@@ -9,10 +9,11 @@
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { FormattedMessage } from '@kbn/i18n/react';
import { EuiFlexGroup, EuiFlexItem, EuiHorizontalRule, EuiPageTemplate } from '@elastic/eui';
import { EuiFlexGroup, EuiFlexItem, EuiHorizontalRule } from '@elastic/eui';
import { METRIC_TYPE } from '@kbn/analytics';
import { i18n } from '@kbn/i18n';
import {
KibanaPageTemplate,
overviewPageActions,
OverviewPageFooter,
} from '../../../../../../src/plugins/kibana_react/public';
@@ -124,9 +125,8 @@ export class Home extends Component {
}

return (
<EuiPageTemplate
<KibanaPageTemplate
pageHeader={{
className: `homPageHeader ${solutions.length ? ' homPageHeader--hasOverlap' : null}`,
pageTitle: <FormattedMessage id="home.header.title" defaultMessage="Home" />,
rightSideItems: overviewPageActions({
addBasePath,
@@ -135,6 +135,7 @@ export class Home extends Component {
showManagementLink: true,
}),
}}
template="empty"
>
{solutions.length ? (
<SolutionsSection
@@ -172,7 +173,7 @@ export class Home extends Component {
trackUiMetric(METRIC_TYPE.CLICK, 'change_to_different_default_route');
}}
/>
</EuiPageTemplate>
</KibanaPageTemplate>
);
}

Original file line number Diff line number Diff line change
@@ -13,7 +13,6 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiHorizontalRule,
EuiPageTemplate,
EuiScreenReaderOnly,
EuiSpacer,
EuiTitle,
@@ -24,6 +23,7 @@ import { CoreStart } from 'kibana/public';
import {
RedirectAppLinks,
useKibana,
KibanaPageTemplate,
overviewPageActions,
OverviewPageFooter,
} from '../../../../../../src/plugins/kibana_react/public';
@@ -117,9 +117,8 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features }) =>
const remainingApps = kibanaApps.map(({ id }) => id).filter((id) => !mainApps.includes(id));

return (
<EuiPageTemplate
<KibanaPageTemplate
pageHeader={{
className: 'kbnPageHeader',
iconType: 'logoKibana',
pageTitle: <FormattedMessage defaultMessage="Kibana" id="kibanaOverview.header.title" />,
rightSideItems: overviewPageActions({
@@ -128,6 +127,7 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features }) =>
hidden: isNewKibanaInstance,
}),
}}
template="empty"
>
{isNewKibanaInstance ? (
<GettingStarted addBasePath={addBasePath} isDarkTheme={IS_DARK_THEME} apps={kibanaApps} />
@@ -260,6 +260,6 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features }) =>
trackUiMetric(METRIC_TYPE.CLICK, 'change_to_different_default_route');
}}
/>
</EuiPageTemplate>
</KibanaPageTemplate>
);
};