Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip and improve empty results query functional test #102995

Merged
merged 3 commits into from
Jun 23, 2021
Merged

[Discover] Unskip and improve empty results query functional test #102995

merged 3 commits into from
Jun 23, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Jun 22, 2021 •
edited
Loading

Summary

Unskippes and improves the functional test for an empty result in Discover.

Flaky test runner, 100 runs: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1677/

Fixes #89550

Checklist

@kertal kertal added the Feature:Discover Discover Application label Jun 22, 2021
@kertal kertal self-assigned this Jun 23, 2021
@kertal kertal changed the title [Discover] Harden and unskip empty results query functional test [Discover] Unskip and improve empty results query functional test Jun 23, 2021
@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed :KibanaApp/fix-it-week labels Jun 23, 2021
@kertal kertal marked this pull request as ready for review June 23, 2021 07:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested a review from dimaanj June 23, 2021 07:17
@kertal
Copy link
Member Author

kertal commented Jun 23, 2021

Test failure is unrelated

@kertal
Copy link
Member Author

kertal commented Jun 23, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal merged commit 77b5b23 into elastic:master Jun 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
@kertal @kibanamachine
[Discover] Unskip and improve empty results query functional test (el…
8218b77 
…astic#102995)
@kibanamachine kibanamachine mentioned this pull request Jun 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
@kibanamachine @kertal
[Discover] Unskip and improve empty results query functional test (#1…
eea0add 
…02995) (#103110)

Co-authored-by: Matthias Wilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaanj dimaanj dimaanj approved these changes

Assignees

@kertal kertal

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@kertal @elasticmachine @kibanamachine @dimaanj