Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Disable missing switch for non-string fields #102865

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[Lens] Disable missing switch for non-string fields #102865

merged 1 commit into from
Jun 23, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #102640

Missing bucket is only supported for string field. This PR makes sure this is correctly reflected in the Lens UI.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 22, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +196.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 22, 2021 11:28
@flash1293 flash1293 requested a review from a team June 22, 2021 11:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

dej611
dej611 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flash1293 flash1293 merged commit 2ab5d6b into elastic:master Jun 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
@flash1293 @kibanamachine
disable missing switch for non-string fields (elastic#102865)
f5d83a2
@kibanamachine kibanamachine mentioned this pull request Jun 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
@kibanamachine @flash1293
disable missing switch for non-string fields (#102865) (#103073)
e583c6d 
Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] "Top Values" allows setting missing values switch for numeric fields
4 participants
@flash1293 @kibanamachine @elasticmachine @dej611