[Integrations UI] Add updated integrations subtitle #102738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Jun 21, 2021
| const HeroImage = memo(() => { | ||
| const { toAssets } = useLinks(); | ||
| const { uiSettings } = useStartServices(); | ||
| const IS_DARK_THEME = uiSettings.get('theme:darkMode'); |
There was a problem hiding this comment.
I am wondering what is the best way to get that settings, you can also get it like this useTheme().darkMode
There was a problem hiding this comment.
I copied this component from the previous header.tsx file which was unused. I will update this to use the hook approach.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 21, 2021
* Add updated integrations subtitle * Fix header image declarations * Use theme hook for dark mode setting
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 21, 2021
* Add updated integrations subtitle * Fix header image declarations * Use theme hook for dark mode setting Co-authored-by: Kyle Pollich <[email protected]>
|
Hi @EricDavisX
Screenshot: Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an updated subtitle for the Integrations UI per @hbharding's direction in #102317 (comment)
Screenshot
Closes #102317