[Lens] Escape field names in formula

[wylieconlon]

If your field name contains any invalid characters, it will get added as a quoted string. For example my 'invalid' field becomes 'my \'invalid\' field'

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

Tested and works as expected, LGTM

Now we should automatically insert quotes when using these field names in the generate logic, but we can do this separately

[dej611]

the only issue I fund was if I start to type the field already with a quote wrapping, selecting the field half-way from the suggestion box will add extra wrapping leading to an error state.

I guess it's something probably not so infrequent if there's a field to escape in the indexpattern, but it's not a blocking feature for this PR:

[dej611]

Still related to this, but it can be addressed in a separated PR as well if this is merged, we should escape incoming fields when transitioning from quick functions:

[wylieconlon]

@flash1293 @dej611 I've updated this PR with fixes for the following cases:

• Switching from quick function with special characters -> formula
• Typing a field name with quotes will replace the entire word, not just append

[flash1293]

@elasticmachine merge upstream

[flash1293]

Failed twice in exactly the same way:

Kibana spaces page meets a11y validations
a11y test for space selection page:

Probably some upstream issue

[flash1293]

Tested and works as expected, LGTM

[wylieconlon]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 55341cb
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	1.3MB	1.3MB	+69.0B
lens	1.5MB	1.5MB	+640.0B
total			+709.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
expressions	210.2KB	210.2KB	+69.0B

History

• 💔 Build #133580 failed 1cf3c70
• 💚 Build #133305 succeeded dcf5be5
• 💚 Build #132288 succeeded a5eea19

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.