Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Add comments to some alerting plugin public API items (#101551) #102130

Merged
merged 1 commit into from
Jun 14, 2021
Merged

[7.x] Add comments to some alerting plugin public API items (#101551) #102130

merged 1 commit into from
Jun 14, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@stacey-gammon @kibanamachine @ymao1
Add comments to some alerting plugin public API items (elastic#101551)
319e111 
* Add comments. Remove ruleType as the second param, not needed.

* Add comments. Remove ruleType as the second param, not needed.

* Fix bad type check and update docs

* update docs

* Remove unused import

* change exports to type to avoid increasing bundle size

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <[email protected]>

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <[email protected]>

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: ymao1 <[email protected]>
@kibanamachine kibanamachine enabled auto-merge (squash) June 14, 2021 19:46
@kibanamachine kibanamachine mentioned this pull request Jun 14, 2021
Merged
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 213 206 -7

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
alerting 15 14 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 61.4KB 61.3KB -154.0B
Unknown metric groups

API count

id before after diff
alerting 213 214 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @stacey-gammon

@kibanamachine kibanamachine merged commit e0f2ed9 into elastic:7.x Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stacey-gammon stacey-gammon

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibanamachine @stacey-gammon