-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Expression reveal image. #101987
Merged
Kuznietsov
merged 93 commits into
elastic:master
from
Kuznietsov:expression_reveal_image
Jul 1, 2021
Merged
Changes from 85 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
63ad0f8
expression_reveal_image skeleton.
Kuznietsov 1240bb2
expression_functions added.
Kuznietsov 72eac63
expression_renderers added.
Kuznietsov 9e1e817
Backup of daily work.
Kuznietsov befec5d
Fixed errors.
Kuznietsov d60f43a
Merge branch 'master' into expression_reveal_image
kibanamachine 03b214f
Added legacy support. Added button for legacy.
Kuznietsov cbbf981
Merge branch 'expression_reveal_image' of github.com:Kunzetsov/kibana…
Kuznietsov 010b7b9
Added storybook.
Kuznietsov 13789f1
Removed revealImage from canvas.
Kuznietsov 96ec59b
setState while rendering error fixed.
Kuznietsov fc13023
tsconfig.json added.
Kuznietsov 4196c5d
jest.config.js added.
Kuznietsov 6be3ccf
Demo doc added.
Kuznietsov b317f8b
Types fixed.
Kuznietsov 784450d
added limits.
Kuznietsov 5de41e6
Removed not used imports.
Kuznietsov 788c5f6
i18n namespaces fixed.
Kuznietsov 3d6d5f3
Fixed test suite error.
Kuznietsov 4911e14
Some errors fixed.
Kuznietsov 3fb130a
Fixed eslint error.
Kuznietsov 273a2a2
Removed more unused translations.
Kuznietsov 02ed217
Moved UI and elements, related to expressionRevealImage from canvas.
Kuznietsov 2e1e9bf
Fixed unused translations errors.
Kuznietsov 2e727cd
Moved type of element to types.
Kuznietsov 9680733
Fixed types and added service for representing elements, ui and suppo…
Kuznietsov 3aebdf6
Added expression registration to canvas.
Kuznietsov 49e52b0
Fixed
Kuznietsov 5f9ab82
Fixed mutiple call of the function.
Kuznietsov 0c11bcd
Removed support of a legacy lib for revealImage chart.
Kuznietsov 2b36c94
Removed legacy presentation_utils plugin import.
Kuznietsov 33b3ec7
Doc error fixed.
Kuznietsov 82352a9
Merge branch 'master' into expression_reveal_image
kibanamachine aa1f474
Removed useless translations and tried to fix error.
Kuznietsov 181f793
Merge branch 'expression_reveal_image' of github.com:Kunzetsov/kibana…
Kuznietsov 7bad366
One more fix.
Kuznietsov 2983097
Small imports fix.
Kuznietsov bf6c8ff
Merge branch 'master' into expression_reveal_image
kibanamachine 226fc89
Fixed translations.
Kuznietsov ccd4450
Made fixes based on nits.
Kuznietsov 390a547
Removed useless params.
Kuznietsov ec78576
fix.
Kuznietsov 55b21d0
Fixed errors, related to jest and __mocks__.
Kuznietsov 19e9024
Removed useless type definition.
Kuznietsov bdea22a
Replaced RendererHandlers with IInterpreterRendererHandlers.
Kuznietsov b4eaa1b
fixed supported_shareable.
Kuznietsov d552813
Moved elements back to canvas.
Kuznietsov 596a027
Moved views to canvas, removed expression service and imported render…
Kuznietsov 40af512
Fixed translations.
Kuznietsov 6ba2baa
Types fix.
Kuznietsov 8994828
Moved libs to presentation utils.
Kuznietsov 7e71064
Fixed one mistake.
Kuznietsov 199e16a
removed dataurl lib.
Kuznietsov fd998f1
Fixed jest files.
Kuznietsov 5b95af7
elasticLogo removed.
Kuznietsov a290c31
Removed elastic_outline.
Kuznietsov 29e3712
removed httpurl.
Kuznietsov 4f2b9f9
Removed missing_asset.
Kuznietsov 94dbd16
removed url.
Kuznietsov ce8c17b
replaced mostly all tests.
Kuznietsov 7dc4ae5
Fixed types.
Kuznietsov b2cd923
Fixed types and removed function_wrapper.ts
Kuznietsov cc7c509
Fixed types of test helpers.
Kuznietsov f0200f2
Merge branch 'master' into expression_reveal_image
Kuznietsov 340093f
Changed limits of presentationUtil plugin.
Kuznietsov 1e98dc0
Fixed imports.
Kuznietsov 84d193c
One more fix.
Kuznietsov e97aa5b
Fixed huge size of bundle.
Kuznietsov 3be24f6
Reduced allow limit for presentationUtil
Kuznietsov 9bf774c
Updated limits for presentationUtil.
Kuznietsov fec9bed
Fixed public API.
Kuznietsov b65b887
fixed type errors.
Kuznietsov ba3a5dd
Merge branch 'master' into expression_reveal_image
kibanamachine 8d722b1
Moved css to component.
Kuznietsov 7dd9049
Fixed spaces at element.
Kuznietsov 4d3aa2d
Changed order of requiredPlugins.
Kuznietsov 10e3617
Updated limits.
Kuznietsov e66bb1a
Removed unused plugin.
Kuznietsov ef67341
Added rule for allowing import from __stories__ directory.
Kuznietsov 93b54b0
removed useless comment.
Kuznietsov 2241b17
Changed readme.md
Kuznietsov 086e34a
Fixed docs error.
Kuznietsov baa0a54
Merge branch 'master' into expression_reveal_image
kibanamachine 493d40e
Merge branch 'master' into expression_reveal_image
kibanamachine 8c3e2d3
A possible of smoke test.
Kuznietsov 2831359
Merge branch 'master' into expression_reveal_image
Kuznietsov 563a671
Merge branch 'master' into expression_reveal_image
kibanamachine 3b2ed6a
onResize changed to useResizeObserver.
Kuznietsov fb7a16c
Remove useless events and `useEffect` block.
Kuznietsov febc98c
Changed from passing handlers to separate functions.
Kuznietsov 56f7303
`function` moved to `server`.
Kuznietsov 9015bb3
Merge branch 'master' into expression_reveal_image
Kuznietsov 436b698
Fixed eslint error.
Kuznietsov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"prefix": "expressionRevealImage", | ||
"paths": { | ||
"expressionRevealImage": "." | ||
}, | ||
"translations": ["translations/ja-JP.json"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
// eslint-disable-next-line import/no-commonjs | ||
module.exports = require('@kbn/storybook').defaultConfig; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# expressionRevealImage | ||
|
||
Expression Reveal Image plugin adds a `revealImage` function to the expression plugin and an associated renderer. The renderer will display the given percentage of a given image. | ||
|
||
--- | ||
|
||
## Development | ||
|
||
See the [kibana contributing guide](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md) for instructions setting up your development environment. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
export const PLUGIN_ID = 'expressionRevealImage'; | ||
export const PLUGIN_NAME = 'expressionRevealImage'; |
10 changes: 10 additions & 0 deletions
10
src/plugins/expression_reveal_image/common/i18n/constants.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export const BASE64 = '`base64`'; | ||
export const URL = 'URL'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
src/plugins/expression_reveal_image/common/i18n/expression_functions/function_errors.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { errors as revealImage } from './dict/reveal_image'; | ||
|
||
export const getFunctionErrors = () => ({ | ||
revealImage, | ||
}); |
21 changes: 21 additions & 0 deletions
21
src/plugins/expression_reveal_image/common/i18n/expression_functions/function_help.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { help as revealImage } from './dict/reveal_image'; | ||
|
||
/** | ||
* Help text for Canvas Functions should be properly localized. This function will | ||
* return a dictionary of help strings, organized by `ExpressionFunctionDefinition` | ||
* specification and then by available arguments within each `ExpressionFunctionDefinition`. | ||
* | ||
* This a function, rather than an object, to future-proof string initialization, | ||
* if ever necessary. | ||
*/ | ||
export const getFunctionHelp = () => ({ | ||
revealImage, | ||
}); |
10 changes: 10 additions & 0 deletions
10
src/plugins/expression_reveal_image/common/i18n/expression_functions/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export * from './function_help'; | ||
export * from './function_errors'; |
9 changes: 9 additions & 0 deletions
9
src/plugins/expression_reveal_image/common/i18n/expression_renderers/dict/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export { strings as revealImage } from './reveal_image'; |
19 changes: 19 additions & 0 deletions
19
src/plugins/expression_reveal_image/common/i18n/expression_renderers/dict/reveal_image.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
import { i18n } from '@kbn/i18n'; | ||
|
||
export const strings = { | ||
getDisplayName: () => | ||
i18n.translate('expressionRevealImage.renderer.revealImage.displayName', { | ||
defaultMessage: 'Image reveal', | ||
}), | ||
getHelpDescription: () => | ||
i18n.translate('expressionRevealImage.renderer.revealImage.helpDescription', { | ||
defaultMessage: 'Reveal a percentage of an image to make a custom gauge-style chart', | ||
}), | ||
}; |
9 changes: 9 additions & 0 deletions
9
src/plugins/expression_reveal_image/common/i18n/expression_renderers/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export * from './renderer_strings'; |
21 changes: 21 additions & 0 deletions
21
src/plugins/expression_reveal_image/common/i18n/expression_renderers/renderer_strings.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { revealImage } from './dict'; | ||
|
||
/** | ||
* Help text for Canvas Functions should be properly localized. This function will | ||
* return a dictionary of help strings, organized by `ExpressionFunctionDefinition` | ||
* specification and then by available arguments within each `ExpressionFunctionDefinition`. | ||
* | ||
* This a function, rather than an object, to future-proof string initialization, | ||
* if ever necessary. | ||
*/ | ||
export const getRendererStrings = () => ({ | ||
revealImage, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export * from './expression_functions'; | ||
export * from './expression_renderers'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export * from './constants'; |
42 changes: 42 additions & 0 deletions
42
src/plugins/expression_reveal_image/common/types/expression_functions.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
import { ExpressionFunctionDefinition, ExpressionValueRender } from 'src/plugins/expressions'; | ||
|
||
export enum Origin { | ||
TOP = 'top', | ||
LEFT = 'left', | ||
BOTTOM = 'bottom', | ||
RIGHT = 'right', | ||
} | ||
|
||
interface Arguments { | ||
image: string | null; | ||
emptyImage: string | null; | ||
origin: Origin; | ||
} | ||
|
||
export interface Output { | ||
image: string; | ||
emptyImage: string; | ||
origin: Origin; | ||
percent: number; | ||
} | ||
|
||
export type ExpressionRevealImageFunction = () => ExpressionFunctionDefinition< | ||
'revealImage', | ||
number, | ||
Arguments, | ||
ExpressionValueRender<Output> | ||
>; | ||
|
||
export enum Position { | ||
TOP = 'top', | ||
BOTTOM = 'bottom', | ||
LEFT = 'left', | ||
RIGHT = 'right', | ||
} |
20 changes: 20 additions & 0 deletions
20
src/plugins/expression_reveal_image/common/types/expression_renderers.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export type OriginString = 'bottom' | 'left' | 'top' | 'right'; | ||
export interface RevealImageRendererConfig { | ||
percent: number; | ||
origin?: OriginString; | ||
image?: string; | ||
emptyImage?: string; | ||
} | ||
|
||
export interface NodeDimensions { | ||
width: number; | ||
height: number; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
export * from './expression_functions'; | ||
export * from './expression_renderers'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
module.exports = { | ||
preset: '@kbn/test', | ||
rootDir: '../../..', | ||
roots: ['<rootDir>/src/plugins/expression_reveal_image'], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"id": "expressionRevealImage", | ||
"version": "1.0.0", | ||
"kibanaVersion": "kibana", | ||
"server": false, | ||
"ui": true, | ||
"requiredPlugins": ["expressions", "presentationUtil"], | ||
"optionalPlugins": [], | ||
"requiredBundles": [] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bulk of this increase comes from moving all those images over. Is there a way we can pull some of those images out of the main bundle and load them async. Maybe we investigate that in a followup pull request.
Also, please update the limits for expressionREvealImage below as it's gotten much smaller as a result of moving the stuff to PresentationUtil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.