-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Add owner and description properties to Uptime's kibana.json #101963
[Uptime] Add owner and description properties to Uptime's kibana.json #101963
Conversation
Pinging @elastic/uptime (Team:uptime) |
x-pack/plugins/uptime/kibana.json
Outdated
"name": "Uptime", | ||
"githubTeam": "uptime" | ||
}, | ||
"description": "This plugin visualizes data from Uptime and Elastic Synthetics, and integrates with other Observability solutions." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just say from Synthetics and Heartbeat
since data doesn't come from Uptime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after my minor comment is addressed.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…elastic#101963) Co-authored-by: Shahzad <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…#101963) (#102041) Co-authored-by: Shahzad <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Justin Kambic <[email protected]> Co-authored-by: Shahzad <[email protected]>
…elastic#101963) Co-authored-by: Shahzad <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
It's been announced that all Kibana plugins must add these fields to their
kibana.json
files.I've added some initial copy here but would like feedback on how we want the plugin to show up in the Kibana developer guide.
note: the only material changes are those at the bottom. The rest of the diff is just the result of my editor auto-formatting per Prettier.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers